From 79743b0528aab02bab662d284a37610b98e42492 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Fri, 29 Aug 2008 00:26:54 +0000 Subject: [PATCH] Tiny micro optimization on test data generation --- .../AbstractSocketCompatibleObjectStreamEchoTest.java | 9 +++------ .../AbstractSocketObjectStreamEchoTest.java | 9 +++------ .../codec/string/AbstractSocketStringEchoTest.java | 9 +++------ 3 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketCompatibleObjectStreamEchoTest.java b/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketCompatibleObjectStreamEchoTest.java index 2780fccd28..5cc888aaa9 100644 --- a/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketCompatibleObjectStreamEchoTest.java +++ b/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketCompatibleObjectStreamEchoTest.java @@ -45,8 +45,6 @@ import org.jboss.netty.channel.ChannelStateEvent; import org.jboss.netty.channel.ExceptionEvent; import org.jboss.netty.channel.MessageEvent; import org.jboss.netty.channel.SimpleChannelHandler; -import org.jboss.netty.handler.codec.serialization.CompatibleObjectDecoder; -import org.jboss.netty.handler.codec.serialization.CompatibleObjectEncoder; import org.junit.AfterClass; import org.junit.BeforeClass; import org.junit.Test; @@ -69,13 +67,12 @@ public abstract class AbstractSocketCompatibleObjectStreamEchoTest { static { for (int i = 0; i < data.length; i ++) { int eLen = random.nextInt(512); - StringBuilder e = new StringBuilder(eLen); - + char[] e = new char[eLen]; for (int j = 0; j < eLen; j ++) { - e.append((char) ('a' + random.nextInt(26))); + e[j] = (char) ('a' + random.nextInt(26)); } - data[i] = e.toString(); + data[i] = new String(e); } } diff --git a/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketObjectStreamEchoTest.java b/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketObjectStreamEchoTest.java index bc05d01846..3b79d1934f 100644 --- a/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketObjectStreamEchoTest.java +++ b/src/test/java/org/jboss/netty/handler/codec/serialization/AbstractSocketObjectStreamEchoTest.java @@ -45,8 +45,6 @@ import org.jboss.netty.channel.ChannelStateEvent; import org.jboss.netty.channel.ExceptionEvent; import org.jboss.netty.channel.MessageEvent; import org.jboss.netty.channel.SimpleChannelHandler; -import org.jboss.netty.handler.codec.serialization.ObjectDecoder; -import org.jboss.netty.handler.codec.serialization.ObjectEncoder; import org.junit.AfterClass; import org.junit.BeforeClass; import org.junit.Test; @@ -69,13 +67,12 @@ public abstract class AbstractSocketObjectStreamEchoTest { static { for (int i = 0; i < data.length; i ++) { int eLen = random.nextInt(512); - StringBuilder e = new StringBuilder(eLen); - + char[] e = new char[eLen]; for (int j = 0; j < eLen; j ++) { - e.append((char) ('a' + random.nextInt(26))); + e[j] = (char) ('a' + random.nextInt(26)); } - data[i] = e.toString(); + data[i] = new String(e); } } diff --git a/src/test/java/org/jboss/netty/handler/codec/string/AbstractSocketStringEchoTest.java b/src/test/java/org/jboss/netty/handler/codec/string/AbstractSocketStringEchoTest.java index ae9a5f809a..a0d4b5b4a4 100644 --- a/src/test/java/org/jboss/netty/handler/codec/string/AbstractSocketStringEchoTest.java +++ b/src/test/java/org/jboss/netty/handler/codec/string/AbstractSocketStringEchoTest.java @@ -47,8 +47,6 @@ import org.jboss.netty.channel.MessageEvent; import org.jboss.netty.channel.SimpleChannelHandler; import org.jboss.netty.handler.codec.frame.DelimiterBasedFrameDecoder; import org.jboss.netty.handler.codec.frame.Delimiters; -import org.jboss.netty.handler.codec.string.StringDecoder; -import org.jboss.netty.handler.codec.string.StringEncoder; import org.junit.AfterClass; import org.junit.BeforeClass; import org.junit.Test; @@ -71,13 +69,12 @@ public abstract class AbstractSocketStringEchoTest { static { for (int i = 0; i < data.length; i ++) { int eLen = random.nextInt(512); - StringBuilder e = new StringBuilder(eLen); - + char[] e = new char[eLen]; for (int j = 0; j < eLen; j ++) { - e.append((char) ('a' + random.nextInt(26))); + e[j] = (char) ('a' + random.nextInt(26)); } - data[i] = e.toString(); + data[i] = new String(e); } }