andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Move "fallthrough" statement to where fall actually happens Motivation: Static analysis looks for error prone switch case statements. Accidental fall through is one such case, but it is sometimes intentional. To indicate this, the "//fallthrough" comment can be added before the fall.

Browse Source 
The code in question has this comment, but it is *after* the fall
so the static analysis flags it.

This is described in http://errorprone.info/bugpattern/FallThrough

Modifications:
Move fall through comment to where the fall actually occurs

Result:
More compatible with Error Prone tools
This commit is contained in:
Carl Mastrangelo 2017-06-22 15:25:25 -07:00 committed by Norman Maurer
parent b985615522
commit 7baef4fbe8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java
View File

@ -284,8 +284,8 @@ final class EpollEventLoop extends SingleThreadEventLoop {
if (wakenUp == 1) { if (wakenUp == 1) {
Native.eventFdWrite(eventFd.intValue(), 1L); Native.eventFdWrite(eventFd.intValue(), 1L);
} }
default:
// fallthrough // fallthrough
default:
} }
final int ioRatio = this.ioRatio; final int ioRatio = this.ioRatio;