andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added a test for oversized HTTP responses

Browse Source
This commit is contained in:
Trustin Lee 2014-02-20 11:46:41 -08:00
parent 5f62821b84
commit 7d238aaf45
1 changed files with 32 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java
View File

@ -20,6 +20,7 @@ import io.netty.buffer.CompositeByteBuf;
import io.netty.buffer.Unpooled; import io.netty.buffer.Unpooled;
import io.netty.channel.ChannelHandlerContext; import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.embedded.EmbeddedChannel; import io.netty.channel.embedded.EmbeddedChannel;
import io.netty.handler.codec.TooLongFrameException;
import io.netty.handler.codec.http.HttpHeaders.Names; import io.netty.handler.codec.http.HttpHeaders.Names;
import io.netty.util.CharsetUtil; import io.netty.util.CharsetUtil;
import org.easymock.EasyMock; import org.easymock.EasyMock;
@ -107,13 +108,13 @@ public class HttpObjectAggregatorTest {
public void testOversizedRequest() { public void testOversizedRequest() {
EmbeddedChannel embedder = new EmbeddedChannel(new HttpObjectAggregator(4)); EmbeddedChannel embedder = new EmbeddedChannel(new HttpObjectAggregator(4));
HttpRequest message = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "http://localhost"); HttpRequest message = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "http://localhost");
HttpContent chunk1 = releaseLater(new DefaultHttpContent(Unpooled.copiedBuffer("test", CharsetUtil.US_ASCII))); HttpContent chunk1 = new DefaultHttpContent(Unpooled.copiedBuffer("test", CharsetUtil.US_ASCII));
HttpContent chunk2 = releaseLater(new DefaultHttpContent(Unpooled.copiedBuffer("test2", CharsetUtil.US_ASCII))); HttpContent chunk2 = new DefaultHttpContent(Unpooled.copiedBuffer("test2", CharsetUtil.US_ASCII));
HttpContent chunk3 = LastHttpContent.EMPTY_LAST_CONTENT; HttpContent chunk3 = LastHttpContent.EMPTY_LAST_CONTENT;
assertFalse(embedder.writeInbound(message)); assertFalse(embedder.writeInbound(message));
assertFalse(embedder.writeInbound(chunk1.copy())); assertFalse(embedder.writeInbound(chunk1));
assertFalse(embedder.writeInbound(chunk2.copy())); assertFalse(embedder.writeInbound(chunk2));
FullHttpResponse response = embedder.readOutbound(); FullHttpResponse response = embedder.readOutbound();
assertEquals(HttpResponseStatus.REQUEST_ENTITY_TOO_LARGE, response.getStatus()); assertEquals(HttpResponseStatus.REQUEST_ENTITY_TOO_LARGE, response.getStatus());
@ -121,7 +122,7 @@ public class HttpObjectAggregatorTest {
assertFalse(embedder.isOpen()); assertFalse(embedder.isOpen());
try { try {
assertFalse(embedder.writeInbound(chunk3.copy())); assertFalse(embedder.writeInbound(chunk3));
fail(); fail();
} catch (Exception e) { } catch (Exception e) {
assertTrue(e instanceof ClosedChannelException); assertTrue(e instanceof ClosedChannelException);
@ -135,14 +136,14 @@ public class HttpObjectAggregatorTest {
// send a HTTP/1.0 request with no keep-alive header // send a HTTP/1.0 request with no keep-alive header
HttpRequest message = new DefaultHttpRequest(HttpVersion.HTTP_1_0, HttpMethod.GET, "http://localhost"); HttpRequest message = new DefaultHttpRequest(HttpVersion.HTTP_1_0, HttpMethod.GET, "http://localhost");
HttpHeaders.setContentLength(message, 5); HttpHeaders.setContentLength(message, 5);
checkOversizedMessage(message); checkOversizedRequest(message);
} }
@Test @Test
public void testOversizedRequestWithContentLength() { public void testOversizedRequestWithContentLength() {
HttpRequest message = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "http://localhost"); HttpRequest message = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "http://localhost");
HttpHeaders.setContentLength(message, 5); HttpHeaders.setContentLength(message, 5);
checkOversizedMessage(message); checkOversizedRequest(message);
} }
@Test @Test
@ -191,7 +192,7 @@ public class HttpObjectAggregatorTest {
assertFalse(embedder.finish()); assertFalse(embedder.finish());
} }
private static void checkOversizedMessage(HttpMessage message) { private static void checkOversizedRequest(HttpRequest message) {
EmbeddedChannel embedder = new EmbeddedChannel(new HttpObjectAggregator(4)); EmbeddedChannel embedder = new EmbeddedChannel(new HttpObjectAggregator(4));
assertFalse(embedder.writeInbound(message)); assertFalse(embedder.writeInbound(message));
@ -200,10 +201,10 @@ public class HttpObjectAggregatorTest {
assertEquals("0", response.headers().get(Names.CONTENT_LENGTH)); assertEquals("0", response.headers().get(Names.CONTENT_LENGTH));
assertFalse(embedder.isOpen()); assertFalse(embedder.isOpen());
HttpContent chunk1 = releaseLater(new DefaultHttpContent(Unpooled.copiedBuffer("test", CharsetUtil.US_ASCII))); HttpContent chunk1 = new DefaultHttpContent(Unpooled.copiedBuffer("test", CharsetUtil.US_ASCII));
try { try {
embedder.writeInbound(chunk1.copy()); embedder.writeInbound(chunk1);
fail(); fail();
} catch (Exception e) { } catch (Exception e) {
assertTrue(e instanceof ClosedChannelException); assertTrue(e instanceof ClosedChannelException);
@ -211,6 +212,27 @@ public class HttpObjectAggregatorTest {
assertFalse(embedder.finish()); assertFalse(embedder.finish());
} }
@Test
public void testOversizedResponse() {
EmbeddedChannel embedder = new EmbeddedChannel(new HttpObjectAggregator(4));
HttpResponse message = new DefaultHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.OK);
HttpContent chunk1 = new DefaultHttpContent(Unpooled.copiedBuffer("test", CharsetUtil.US_ASCII));
HttpContent chunk2 = new DefaultHttpContent(Unpooled.copiedBuffer("test2", CharsetUtil.US_ASCII));
assertFalse(embedder.writeInbound(message));
assertFalse(embedder.writeInbound(chunk1));
try {
embedder.writeInbound(chunk2);
fail();
} catch (TooLongFrameException expected) {
// Expected
}
assertFalse(embedder.isOpen());
assertFalse(embedder.finish());
}
@Test(expected = IllegalArgumentException.class) @Test(expected = IllegalArgumentException.class)
public void testInvalidConstructorUsage() { public void testInvalidConstructorUsage() {
new HttpObjectAggregator(0); new HttpObjectAggregator(0);