Fix a bug where DefaultPromise.setUncancellable() returns a wrong value
- Fixes #2220 - Its Javadoc says it returns true when the promise is done (but not cancelled) or the promise is uncancellable, but it returns false when the promise is done.
This commit is contained in:
parent
084db044cd
commit
7e0e4c6325
@ -461,14 +461,14 @@ public class DefaultPromise<V> extends AbstractFuture<V> implements Promise<V> {
|
||||
public boolean setUncancellable() {
|
||||
Object result = this.result;
|
||||
if (isDone0(result)) {
|
||||
return false;
|
||||
return isCancelled0(result);
|
||||
}
|
||||
|
||||
synchronized (this) {
|
||||
// Allow only once.
|
||||
result = this.result;
|
||||
if (isDone0(result)) {
|
||||
return false;
|
||||
return isCancelled0(result);
|
||||
}
|
||||
|
||||
this.result = UNCANCELLABLE;
|
||||
|
Loading…
Reference in New Issue
Block a user