andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#4171] Fix flacky test introduced by previous commit.

Browse Source 
Motivation:

SingleThreadEventExecutorTest was flacky.

Modifications:

Fixed flacky test.

Result:

No more test failures
This commit is contained in:
Norman Maurer 2015-08-29 12:29:19 +02:00
parent 52bec9726f
commit 7e5901d581
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java
View File

@ -24,7 +24,7 @@ import java.util.concurrent.atomic.AtomicReference;
public class SingleThreadEventExecutorTest { public class SingleThreadEventExecutorTest {
@Test @Test
public void testThreadDetails() { public void testThreadProperties() {
final AtomicReference<Thread> threadRef = new AtomicReference<Thread>(); final AtomicReference<Thread> threadRef = new AtomicReference<Thread>();
SingleThreadEventExecutor executor = new SingleThreadEventExecutor( SingleThreadEventExecutor executor = new SingleThreadEventExecutor(
null, Executors.newCachedThreadPool(), false) { null, Executors.newCachedThreadPool(), false) {
@ -40,16 +40,13 @@ public class SingleThreadEventExecutorTest {
} }
}; };
ThreadProperties threadProperties = executor.threadProperties(); ThreadProperties threadProperties = executor.threadProperties();
Assert.assertSame(threadProperties, executor.threadProperties());
Thread thread = threadRef.get(); Thread thread = threadRef.get();
Assert.assertEquals(thread.getId(), threadProperties.id()); Assert.assertEquals(thread.getId(), threadProperties.id());
Assert.assertEquals(thread.getName(), threadProperties.name()); Assert.assertEquals(thread.getName(), threadProperties.name());
Assert.assertEquals(thread.getPriority(), threadProperties.priority()); Assert.assertEquals(thread.getPriority(), threadProperties.priority());
Assert.assertEquals(thread.getState(), threadProperties.state());
Assert.assertEquals(thread.isAlive(), threadProperties.isAlive()); Assert.assertEquals(thread.isAlive(), threadProperties.isAlive());
Assert.assertEquals(thread.isDaemon(), threadProperties.isDaemon()); Assert.assertEquals(thread.isDaemon(), threadProperties.isDaemon());
Assert.assertEquals(thread.isInterrupted(), threadProperties.isInterrupted());
Assert.assertTrue(threadProperties.stackTrace().length > 0); Assert.assertTrue(threadProperties.stackTrace().length > 0);
executor.shutdownGracefully(); executor.shutdownGracefully();
} }