andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Correctly handle SocksCmdResponse. Related to #2428

Browse Source 
Motivation:
Ports range check is not correct

Modification:
Allow port between 0 and 65535. 0 is wildcard / unknown port here

Result:
Correct validation
This commit is contained in:
Norman Maurer 2014-04-30 10:40:00 +02:00
parent e6783d173a
commit 82220b0987
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java
View File

@ -90,8 +90,8 @@ public final class SocksCmdResponse extends SocksResponse {
} }
host = IDN.toASCII(host); host = IDN.toASCII(host);
} }
if (port <= 0 && port >= 65536) { if (port < 0 || port > 65535) {
throw new IllegalArgumentException(port + " is not in bounds 0 < x < 65536"); throw new IllegalArgumentException(port + " is not in bounds 0 <= x <= 65535");
} }
this.cmdStatus = cmdStatus; this.cmdStatus = cmdStatus;
this.addressType = addressType; this.addressType = addressType;