From 834277a9ebaec7e53e85e7c37888891d1199d020 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Sun, 16 Nov 2008 11:29:36 +0000 Subject: [PATCH] Potential fix for intermittent SSL test failures --- .../java/org/jboss/netty/handler/ssl/SslHandler.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java index 8d9db87cdc..e2921bcd39 100644 --- a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java +++ b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java @@ -621,10 +621,8 @@ public class SslHandler extends FrameDecoder { runDelegatedTasks(); break; case FINISHED: - setHandshakeSuccess(channel); - wrap(ctx, channel); - break loop; case NOT_HANDSHAKING: + setHandshakeSuccess(channel); wrap(ctx, channel); break loop; default: @@ -666,6 +664,10 @@ public class SslHandler extends FrameDecoder { } private void setHandshakeSuccess(Channel channel) { + if (!handshaking) { + return; + } + synchronized (handshakeLock) { handshaking = false; handshaken = true; @@ -674,6 +676,7 @@ public class SslHandler extends FrameDecoder { handshakeFuture = newHandshakeFuture(channel); } } + handshakeFuture.setSuccess(); }