Possible leak in AbstractDiskHttpData

Motivation:
SonarQube (clinker.netty.io/sonar) reported a resource which may not have been properly closed in all situations in AbstractDiskHttpData.

Modifications:
- Ensure file channels are closed in the presence of exceptions.
- Correct instances where local channels were created but potentially not closed.

Result:
Less leaks. Less SonarQube vulnerabilities.

codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java

@@ -120,16 +120,18 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
                 return;
             }
             FileOutputStream outputStream = new FileOutputStream(file);
-            FileChannel localfileChannel = outputStream.getChannel();
+            try {
-            ByteBuffer byteBuffer = buffer.nioBuffer();
+                FileChannel localfileChannel = outputStream.getChannel();
-            int written = 0;
+                ByteBuffer byteBuffer = buffer.nioBuffer();
-            while (written < size) {
+                int written = 0;
-                written += localfileChannel.write(byteBuffer);
+                while (written < size) {
+                    written += localfileChannel.write(byteBuffer);
+                }
+                buffer.readerIndex(buffer.readerIndex() + written);
+                localfileChannel.force(false);
+            } finally {
+                outputStream.close();
             }
-            buffer.readerIndex(buffer.readerIndex() + written);
-            localfileChannel.force(false);
-            localfileChannel.close();
-            outputStream.close();
             setCompleted();
         } finally {
             // Release the buffer as it was retained before and we not need a reference to it at all
@@ -210,19 +212,22 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
         }
         file = tempFile();
         FileOutputStream outputStream = new FileOutputStream(file);
-        FileChannel localfileChannel = outputStream.getChannel();
-        byte[] bytes = new byte[4096 * 4];
-        ByteBuffer byteBuffer = ByteBuffer.wrap(bytes);
-        int read = inputStream.read(bytes);
         int written = 0;
-        while (read > 0) {
+        try {
-            byteBuffer.position(read).flip();
+            FileChannel localfileChannel = outputStream.getChannel();
-            written += localfileChannel.write(byteBuffer);
+            byte[] bytes = new byte[4096 * 4];
-            checkSize(written);
+            ByteBuffer byteBuffer = ByteBuffer.wrap(bytes);
-            read = inputStream.read(bytes);
+            int read = inputStream.read(bytes);
+            while (read > 0) {
+                byteBuffer.position(read).flip();
+                written += localfileChannel.write(byteBuffer);
+                checkSize(written);
+                read = inputStream.read(bytes);
+            }
+            localfileChannel.force(false);
+        } finally {
+            outputStream.close();
         }
-        localfileChannel.force(false);
-        localfileChannel.close();
         size = written;
         if (definedSize > 0 && definedSize < size) {
             if (!file.delete()) {
@@ -279,7 +284,7 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
             return EMPTY_BUFFER;
         }
         if (fileChannel == null) {
-            FileInputStream  inputStream = new FileInputStream(file);
+            FileInputStream inputStream = new FileInputStream(file);
             fileChannel = inputStream.getChannel();
         }
         int read = 0;
@@ -337,20 +342,51 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
         }
         if (!file.renameTo(dest)) {
             // must copy
-            FileInputStream inputStream = new FileInputStream(file);
+            IOException exception = null;
-            FileOutputStream outputStream = new FileOutputStream(dest);
+            FileInputStream inputStream = null;
-            FileChannel in = inputStream.getChannel();
+            FileOutputStream outputStream = null;
-            FileChannel out = outputStream.getChannel();
             long chunkSize = 8196;
             long position = 0;
-            while (position < size) {
+            try {
-                if (chunkSize < size - position) {
+                inputStream = new FileInputStream(file);
-                    chunkSize = size - position;
+                outputStream = new FileOutputStream(dest);
+                FileChannel in = inputStream.getChannel();
+                FileChannel out = outputStream.getChannel();
+                while (position < size) {
+                    if (chunkSize < size - position) {
+                        chunkSize = size - position;
+                    }
+                    position += in.transferTo(position, chunkSize , out);
+                }
+            } catch (IOException e) {
+                exception = e;
+            } finally {
+                if (inputStream != null) {
+                    try {
+                        inputStream.close();
+                    } catch (IOException e) {
+                        if (exception == null) { // Choose to report the first exception
+                            exception = e;
+                        } else {
+                            logger.warn("Multiple exceptions detected, the following will be suppressed {}", e);
+                        }
+                    }
+                }
+                if (outputStream != null) {
+                    try {
+                        outputStream.close();
+                    } catch (IOException e) {
+                        if (exception == null) { // Choose to report the first exception
+                            exception = e;
+                        } else {
+                            logger.warn("Multiple exceptions detected, the following will be suppressed {}", e);
+                        }
+                    }
                 }
-                position += in.transferTo(position, chunkSize , out);
             }
-            in.close();
+            if (exception != null) {
-            out.close();
+                throw exception;
+            }
             if (position == size) {
                 if (!file.delete()) {
                     logger.warn("Failed to delete: {}", file);
@@ -381,14 +417,17 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
                     "File too big to be loaded in memory");
         }
         FileInputStream inputStream = new FileInputStream(src);
-        FileChannel fileChannel = inputStream.getChannel();
         byte[] array = new byte[(int) srcsize];
-        ByteBuffer byteBuffer = ByteBuffer.wrap(array);
+        try {
-        int read = 0;
+            FileChannel fileChannel = inputStream.getChannel();
-        while (read < srcsize) {
+            ByteBuffer byteBuffer = ByteBuffer.wrap(array);
-            read += fileChannel.read(byteBuffer);
+            int read = 0;
+            while (read < srcsize) {
+                read += fileChannel.read(byteBuffer);
+            }
+        } finally {
+            inputStream.close();
         }
-        fileChannel.close();
         return array;
     }