andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

SelfSignedCertificate should work in http2 tests (#11486)

Browse Source 
Motivation:

We need to add `--add-exports java.base/sun.security.x509=ALL-UNNAMED` when running the tests for codec-http2 as some of the tests use SelfSignedCertificate.

Modifications:

- Add `--add-exports java.base/sun.security.x509=ALL-UNNAMED` when running the tests for codec-http2
- Ensure we export correct when running with JDK12, 13, 14 and 15 as well

Result:

No more tests failure due not be able to access classes
This commit is contained in:
Norman Maurer 2021-07-14 07:46:17 +02:00 committed by GitHub
parent 3b8e7c3e60
commit 876624a22b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-http2/pom.xml
View File

@ -30,6 +30,8 @@
<properties> <properties>
<javaModuleName>io.netty.codec.http2</javaModuleName> <javaModuleName>io.netty.codec.http2</javaModuleName>
<!-- Needed for SSL tests as these use the SelfSignedCertificate -->
<argLine.java9.extras>--add-exports java.base/sun.security.x509=ALL-UNNAMED</argLine.java9.extras>
</properties> </properties>
<dependencies> <dependencies>

9
pom.xml
View File

@ -216,6 +216,9 @@
<jdk>15</jdk> <jdk>15</jdk>
</activation> </activation>
<properties> <properties>
<argLine.java9.extras />
<!-- Export some stuff which is used during our tests -->
<argLine.java9>--illegal-access=deny ${argLine.java9.extras}</argLine.java9>
<!-- Not use alpn agent as Java11+ supports alpn out of the box --> <!-- Not use alpn agent as Java11+ supports alpn out of the box -->
<argLine.alpnAgent /> <argLine.alpnAgent />
<forbiddenapis.skip>true</forbiddenapis.skip> <forbiddenapis.skip>true</forbiddenapis.skip>
@ -237,6 +240,9 @@
<jdk>14</jdk> <jdk>14</jdk>
</activation> </activation>
<properties> <properties>
<argLine.java9.extras />
<!-- Export some stuff which is used during our tests -->
<argLine.java9>--illegal-access=deny ${argLine.java9.extras}</argLine.java9>
<!-- Not use alpn agent as Java11+ supports alpn out of the box --> <!-- Not use alpn agent as Java11+ supports alpn out of the box -->
<argLine.alpnAgent /> <argLine.alpnAgent />
<forbiddenapis.skip>true</forbiddenapis.skip> <forbiddenapis.skip>true</forbiddenapis.skip>
@ -258,6 +264,9 @@
<jdk>13</jdk> <jdk>13</jdk>
</activation> </activation>
<properties> <properties>
<argLine.java9.extras />
<!-- Export some stuff which is used during our tests -->
<argLine.java9>--illegal-access=deny ${argLine.java9.extras}</argLine.java9>
<!-- Not use alpn agent as Java11+ supports alpn out of the box --> <!-- Not use alpn agent as Java11+ supports alpn out of the box -->
<argLine.alpnAgent /> <argLine.alpnAgent />
<forbiddenapis.skip>true</forbiddenapis.skip> <forbiddenapis.skip>true</forbiddenapis.skip>