andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable mutual auth tests on windows for now (#11513)

Browse Source 
Motivation:

We did observe that the mutal auth tests are flaky on windows when running on the CI. Let's disable these for now.

Modifications:

Disable mutual auth tests on windows

Result:

More stable build. Related to https://github.com/netty/netty/issues/11489
This commit is contained in:
Norman Maurer 2021-07-26 14:10:26 +02:00 committed by GitHub
parent ae875c35ec
commit 8af59e4b40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
handler/src/test/java/io/netty/handler/ssl/JdkOpenSslEngineInteroptTest.java
View File

@ -16,7 +16,8 @@
package io.netty.handler.ssl; package io.netty.handler.ssl;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.condition.DisabledOnOs;
import org.junit.jupiter.api.condition.OS;
import javax.net.ssl.SSLEngine; import javax.net.ssl.SSLEngine;
import java.util.ArrayList; import java.util.ArrayList;
@ -60,11 +61,31 @@ public class JdkOpenSslEngineInteroptTest extends SSLEngineTest {
} }
@Override @Override
@Disabled("Disable until figured out why this sometimes fail on the CI") @DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthSameCerts(SSLEngineTestParam param) throws Throwable { public void testMutualAuthSameCerts(SSLEngineTestParam param) throws Throwable {
super.testMutualAuthSameCerts(param); super.testMutualAuthSameCerts(param);
} }
@Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthDiffCerts(SSLEngineTestParam param) throws Exception {
super.testMutualAuthDiffCerts(param);
}
@Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthDiffCertsServerFailure(SSLEngineTestParam param) throws Exception {
super.testMutualAuthDiffCertsServerFailure(param);
}
@Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthDiffCertsClientFailure(SSLEngineTestParam param) throws Exception {
super.testMutualAuthDiffCertsClientFailure(param);
}
@Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthInvalidIntermediateCASucceedWithOptionalClientAuth(SSLEngineTestParam param) public void testMutualAuthInvalidIntermediateCASucceedWithOptionalClientAuth(SSLEngineTestParam param)
throws Exception { throws Exception {
checkShouldUseKeyManagerFactory(); checkShouldUseKeyManagerFactory();
@ -72,6 +93,7 @@ public class JdkOpenSslEngineInteroptTest extends SSLEngineTest {
} }
@Override @Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthInvalidIntermediateCAFailWithOptionalClientAuth(SSLEngineTestParam param) public void testMutualAuthInvalidIntermediateCAFailWithOptionalClientAuth(SSLEngineTestParam param)
throws Exception { throws Exception {
checkShouldUseKeyManagerFactory(); checkShouldUseKeyManagerFactory();
@ -79,6 +101,7 @@ public class JdkOpenSslEngineInteroptTest extends SSLEngineTest {
} }
@Override @Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthInvalidIntermediateCAFailWithRequiredClientAuth(SSLEngineTestParam param) public void testMutualAuthInvalidIntermediateCAFailWithRequiredClientAuth(SSLEngineTestParam param)
throws Exception { throws Exception {
checkShouldUseKeyManagerFactory(); checkShouldUseKeyManagerFactory();
@ -86,6 +109,7 @@ public class JdkOpenSslEngineInteroptTest extends SSLEngineTest {
} }
@Override @Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthValidClientCertChainTooLongFailOptionalClientAuth(SSLEngineTestParam param) public void testMutualAuthValidClientCertChainTooLongFailOptionalClientAuth(SSLEngineTestParam param)
throws Exception { throws Exception {
checkShouldUseKeyManagerFactory(); checkShouldUseKeyManagerFactory();
@ -93,6 +117,7 @@ public class JdkOpenSslEngineInteroptTest extends SSLEngineTest {
} }
@Override @Override
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Disable until figured out why this sometimes fail on the CI")
public void testMutualAuthValidClientCertChainTooLongFailRequireClientAuth(SSLEngineTestParam param) public void testMutualAuthValidClientCertChainTooLongFailRequireClientAuth(SSLEngineTestParam param)
throws Exception { throws Exception {
checkShouldUseKeyManagerFactory(); checkShouldUseKeyManagerFactory();