Remove old internal code that is not used anymore after removing usage of ObjectCleaner (#8956)
Motivation: We dont use ObjectCleaner in our FastThreadLocal anymore so we also dont need to take special care to store it there anymore. Modifications: Remove code that is not needed anymore. Result: Code cleanup.
This commit is contained in:
parent
e3d38d85bd
commit
8b23c85978
|
@ -139,33 +139,7 @@ public class FastThreadLocal<V> {
|
||||||
return (V) v;
|
return (V) v;
|
||||||
}
|
}
|
||||||
|
|
||||||
V value = initialize(threadLocalMap);
|
return initialize(threadLocalMap);
|
||||||
registerCleaner(threadLocalMap);
|
|
||||||
return value;
|
|
||||||
}
|
|
||||||
|
|
||||||
private void registerCleaner(final InternalThreadLocalMap threadLocalMap) {
|
|
||||||
Thread current = Thread.currentThread();
|
|
||||||
if (FastThreadLocalThread.willCleanupFastThreadLocals(current) || threadLocalMap.isCleanerFlagSet(index)) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
threadLocalMap.setCleanerFlag(index);
|
|
||||||
|
|
||||||
// TODO: We need to find a better way to handle this.
|
|
||||||
/*
|
|
||||||
// We will need to ensure we will trigger remove(InternalThreadLocalMap) so everything will be released
|
|
||||||
// and FastThreadLocal.onRemoval(...) will be called.
|
|
||||||
ObjectCleaner.register(current, new Runnable() {
|
|
||||||
@Override
|
|
||||||
public void run() {
|
|
||||||
remove(threadLocalMap);
|
|
||||||
|
|
||||||
// It's fine to not call InternalThreadLocalMap.remove() here as this will only be triggered once
|
|
||||||
// the Thread is collected by GC. In this case the ThreadLocal will be gone away already.
|
|
||||||
}
|
|
||||||
});
|
|
||||||
*/
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -201,9 +175,7 @@ public class FastThreadLocal<V> {
|
||||||
public final void set(V value) {
|
public final void set(V value) {
|
||||||
if (value != InternalThreadLocalMap.UNSET) {
|
if (value != InternalThreadLocalMap.UNSET) {
|
||||||
InternalThreadLocalMap threadLocalMap = InternalThreadLocalMap.get();
|
InternalThreadLocalMap threadLocalMap = InternalThreadLocalMap.get();
|
||||||
if (setKnownNotUnset(threadLocalMap, value)) {
|
setKnownNotUnset(threadLocalMap, value);
|
||||||
registerCleaner(threadLocalMap);
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
remove();
|
remove();
|
||||||
}
|
}
|
||||||
|
@ -223,12 +195,10 @@ public class FastThreadLocal<V> {
|
||||||
/**
|
/**
|
||||||
* @return see {@link InternalThreadLocalMap#setIndexedVariable(int, Object)}.
|
* @return see {@link InternalThreadLocalMap#setIndexedVariable(int, Object)}.
|
||||||
*/
|
*/
|
||||||
private boolean setKnownNotUnset(InternalThreadLocalMap threadLocalMap, V value) {
|
private void setKnownNotUnset(InternalThreadLocalMap threadLocalMap, V value) {
|
||||||
if (threadLocalMap.setIndexedVariable(index, value)) {
|
if (threadLocalMap.setIndexedVariable(index, value)) {
|
||||||
addToVariablesToRemove(threadLocalMap, this);
|
addToVariablesToRemove(threadLocalMap, this);
|
||||||
return true;
|
|
||||||
}
|
}
|
||||||
return false;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in New Issue
Block a user