From 8cb5d0fa8ceba19e5df5062b57d806556589770c Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Fri, 11 Aug 2017 00:12:21 -0700 Subject: [PATCH] SocketGatheringWriteTest increase timeouts Motivation: EpollDomainSocketGatheringWriteTest. testGatheringWriteBig takes on average about 20-25 seconds on the CI servers, but there is a 30 second timeout being applied which leads to what maybe false positive test failures. Modifications: - Increase the test timeout to 120 seconds globally and 60 seconds to wait for all writes per test Result: Higher timeout for potentially less false positive test failures. --- .../testsuite/transport/socket/SocketGatheringWriteTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketGatheringWriteTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketGatheringWriteTest.java index 888d465f23..d04c6cd166 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketGatheringWriteTest.java +++ b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketGatheringWriteTest.java @@ -47,7 +47,7 @@ import static org.junit.Assert.assertTrue; public class SocketGatheringWriteTest extends AbstractSocketTest { @Rule - public final Timeout globalTimeout = new Timeout(60000); + public final Timeout globalTimeout = new Timeout(120000); private static final Random random = new Random(); static final byte[] data = new byte[1048576]; @@ -141,7 +141,7 @@ public class SocketGatheringWriteTest extends AbstractSocketTest { ChannelFuture cf = cc.writeAndFlush(Unpooled.EMPTY_BUFFER); assertNotEquals(cc.voidPromise(), cf); try { - assertTrue(cf.await(30000)); + assertTrue(cf.await(60000)); cf.sync(); } catch (Throwable t) { // TODO: Remove this once we fix this test.