andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

OpenSsl.USE_KEYMANAGER_FACTORY incorrectly set to false with BoringSSL (#9175)

Browse Source 
Motivation

SSL unit tests started failing for me (RHEL 7.6) after #9162. It looks
like the intention was to prevent disable use of the
io.netty.handler.ssl.openssl.useKeyManagerFactory property when using
BoringSSL, but it now gets set to false in that case rather than the
prior/non-BoringSSL default of true.

Modification

Set useKeyManagerFactory to true rather than false in BoringSSL case
during static init of OpenSSl class.

Result

Tests pass again.
This commit is contained in:
Nick Hill 2019-05-22 22:09:55 -07:00 committed by Norman Maurer
parent 128403b492
commit 8ce3d52c0e
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
View File

@ -260,6 +260,7 @@ public final class OpenSsl {
" is deprecated and so will be ignored in the future"); " is deprecated and so will be ignored in the future");
} }
} else { } else {
useKeyManagerFactory = true;
if (propertySet) { if (propertySet) {
logger.info("System property " + logger.info("System property " +
"'io.netty.handler.ssl.openssl.useKeyManagerFactory'" + "'io.netty.handler.ssl.openssl.useKeyManagerFactory'" +