From 907ed79069584b6c4641bfe4bf9f64eea2c23564 Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Mon, 20 Nov 2017 12:36:36 -0800 Subject: [PATCH] Reduce conditionals in DnsNameResovlerContext Motivation: Minor cleanup from 844d804 just to reduce the conditional statements and indentation level. Modifications: - combine the else + if into an else if statement Result: Code cleaned up. --- .../io/netty/resolver/dns/DnsNameResolverContext.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java index b8590fc750..389693bc40 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java +++ b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java @@ -141,12 +141,10 @@ abstract class DnsNameResolverContext { promise.trySuccess(future.getNow()); } else if (searchDomainIdx < searchDomains.length) { doSearchDomainQuery(hostname + '.' + searchDomains[searchDomainIdx++], this); + } else if (!startWithoutSearchDomain) { + internalResolve(promise); } else { - if (!startWithoutSearchDomain) { - internalResolve(promise); - } else { - promise.tryFailure(new SearchDomainUnknownHostException(future.cause(), hostname)); - } + promise.tryFailure(new SearchDomainUnknownHostException(future.cause(), hostname)); } } });