From 90b788bef7ead86a2456d0c7b2587021907d341d Mon Sep 17 00:00:00 2001 From: YuanHu Date: Mon, 22 Jul 2019 03:06:31 +0800 Subject: [PATCH] Recycler availableSharedCapacity will be slowly exhausted due missing reclaimSpace(...) call (#9394) Motivation: We did miss to call reclaimSpace(...) in one case which can lead to the situation of having the Recycler to not correctly reclaim space and so just create new objects when not needed. Modifications: Correctly call reclaimSpace(...) Result: Recycler correctly reclaims space in all situations. --- common/src/main/java/io/netty/util/Recycler.java | 1 + 1 file changed, 1 insertion(+) diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java index 8e5f87dfe1..732a391082 100644 --- a/common/src/main/java/io/netty/util/Recycler.java +++ b/common/src/main/java/io/netty/util/Recycler.java @@ -384,6 +384,7 @@ public abstract class Recycler { return false; } this.head.link = head = head.next; + this.head.reclaimSpace(LINK_CAPACITY); } final int srcStart = head.readIndex;