andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleanup test classes

Browse Source 
Motivation:

We had some println left in the test-classes.

Modifications:

Remove println usage

Result:

Cleanup
This commit is contained in:
Norman Maurer 2021-05-12 14:39:50 +02:00
parent f33acf2009
commit 91e41ae66e
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
buffer/src/test/java/io/netty/buffer/AdvancedLeakAwareByteBufTest.java
View File

@ -46,7 +46,6 @@ public class AdvancedLeakAwareByteBufTest extends SimpleLeakAwareByteBufTest {
composite.addComponent(true, leakAwareBuf); composite.addComponent(true, leakAwareBuf);
byte[] result = new byte[5]; byte[] result = new byte[5];
ByteBuf bb = composite.component(0); ByteBuf bb = composite.component(0);
System.out.println(bb);
bb.readBytes(result); bb.readBytes(result);
assertArrayEquals("world".getBytes(CharsetUtil.US_ASCII), result); assertArrayEquals("world".getBytes(CharsetUtil.US_ASCII), result);
composite.release(); composite.release();

2
resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverClientSubnetTest.java
View File

@ -49,7 +49,7 @@ public class DnsNameResolverClientSubnetTest {
new DefaultDnsOptEcsRecord(1024, 24, new DefaultDnsOptEcsRecord(1024, 24,
SocketUtils.addressByName("157.88.0.0").getAddress()))); SocketUtils.addressByName("157.88.0.0").getAddress())));
for (InetAddress address: future.syncUninterruptibly().getNow()) { for (InetAddress address: future.syncUninterruptibly().getNow()) {
System.err.println(address); System.out.println(address);
} }
} finally { } finally {
resolver.close(); resolver.close();

7
resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
View File

@ -497,11 +497,8 @@ public class DnsNameResolverTest {
for (Entry<String, InetAddress> e : resultA.entrySet()) { for (Entry<String, InetAddress> e : resultA.entrySet()) {
InetAddress expected = e.getValue(); InetAddress expected = e.getValue();
InetAddress actual = resultB.get(e.getKey()); InetAddress actual = resultB.get(e.getKey());
if (!actual.equals(expected)) { assertThat("Cache for " + e.getKey() + ": " + resolver.resolveAll(e.getKey()).getNow(),
// Print the content of the cache when test failure is expected. actual, is(expected));
System.err.println("Cache for " + e.getKey() + ": " + resolver.resolveAll(e.getKey()).getNow());
}
assertThat(actual, is(expected));
} }
} finally { } finally {
resolver.close(); resolver.close();