From 923dde7a5f4d2a47785ba9e874eae8a31d130844 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Thu, 3 Jan 2013 16:01:41 +0900 Subject: [PATCH] Do not auto-start read operation --- .../java/io/netty/channel/socket/nio/NioDatagramChannel.java | 2 -- .../java/io/netty/channel/socket/nio/NioSctpChannel.java | 5 +---- .../java/io/netty/channel/socket/nio/NioSocketChannel.java | 5 +---- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java index 0a351dd569..4ecd6f713a 100755 --- a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java +++ b/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java @@ -153,7 +153,6 @@ public final class NioDatagramChannel @Override protected void doBind(SocketAddress localAddress) throws Exception { javaChannel().socket().bind(localAddress); - selectionKey().interestOps(SelectionKey.OP_READ); } @Override @@ -166,7 +165,6 @@ public final class NioDatagramChannel boolean success = false; try { javaChannel().connect(remoteAddress); - selectionKey().interestOps(selectionKey().interestOps() | SelectionKey.OP_READ); success = true; return true; } finally { diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioSctpChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioSctpChannel.java index 9e4580051d..cf409fe092 100644 --- a/transport/src/main/java/io/netty/channel/socket/nio/NioSctpChannel.java +++ b/transport/src/main/java/io/netty/channel/socket/nio/NioSctpChannel.java @@ -211,9 +211,7 @@ public class NioSctpChannel extends AbstractNioMessageChannel implements io.nett boolean success = false; try { boolean connected = javaChannel().connect(remoteAddress); - if (connected) { - selectionKey().interestOps(SelectionKey.OP_READ); - } else { + if (!connected) { selectionKey().interestOps(SelectionKey.OP_CONNECT); } success = true; @@ -230,7 +228,6 @@ public class NioSctpChannel extends AbstractNioMessageChannel implements io.nett if (!javaChannel().finishConnect()) { throw new Error(); } - selectionKey().interestOps(SelectionKey.OP_READ); } @Override diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java index c984ccd714..647a49f2f0 100755 --- a/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java +++ b/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java @@ -174,9 +174,7 @@ public class NioSocketChannel extends AbstractNioByteChannel implements io.netty boolean success = false; try { boolean connected = javaChannel().connect(remoteAddress); - if (connected) { - selectionKey().interestOps(SelectionKey.OP_READ); - } else { + if (!connected) { selectionKey().interestOps(SelectionKey.OP_CONNECT); } success = true; @@ -193,7 +191,6 @@ public class NioSocketChannel extends AbstractNioByteChannel implements io.netty if (!javaChannel().finishConnect()) { throw new Error(); } - selectionKey().interestOps(SelectionKey.OP_READ); } @Override