andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

NioServerBossPool : init() must be called after super(...) otherwise thread name determiner is not used

Browse Source
This commit is contained in:
Michael Morello 2013-01-24 15:11:27 +01:00 committed by Norman Maurer
parent 627686bdb4
commit 923e69251b
2 changed files with 60 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/org/jboss/netty/channel/socket/nio/NioServerBossPool.java
View File

@ -35,8 +35,9 @@ public class NioServerBossPool extends AbstractNioBossPool<NioServerBoss> {
* if you not want to set one explicit.
*/
public NioServerBossPool(Executor bossExecutor, int bossCount, ThreadNameDeterminer determiner) {
super(bossExecutor, bossCount);
super(bossExecutor, bossCount, false);
this.determiner = determiner;
init();
}
/**

58
src/test/java/org/jboss/netty/channel/socket/nio/NioServerBossPoolTest.java Normal file
View File

@ -0,0 +1,58 @@
package org.jboss.netty.channel.socket.nio;
import static org.junit.Assert.*;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import org.jboss.netty.util.ThreadNameDeterminer;
import org.jboss.netty.util.internal.ExecutorUtil;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;
public class NioServerBossPoolTest {
private static ExecutorService executor;
@BeforeClass
public static void init() {
executor = Executors.newCachedThreadPool();
}
@AfterClass
public static void destroy() {
ExecutorUtil.terminate(executor);
}
private static final String MY_CUSTOM_THREAD_NAME = "FOO";
private final ThreadNameDeterminer determiner = new ThreadNameDeterminer() {
public String determineThreadName(String currentThreadName,
String proposedThreadName) throws Exception {
return MY_CUSTOM_THREAD_NAME;
}
};
@Test
public void testNioServerBossPoolExecutorIntThreadNameDeterminer()
throws Exception {
NioServerBossPool bossPool = null;
try {
bossPool = new NioServerBossPool(executor, 1, determiner);
NioServerBoss nextBoss = bossPool.nextBoss();
assertNotNull(nextBoss);
// Wait for ThreadRenamingRunnable to be run by the executor
Thread.sleep(1000);
// Ok, now there should be thread
assertNotNull(nextBoss.thread);
assertEquals(MY_CUSTOM_THREAD_NAME, nextBoss.thread.getName());
} finally {
if (bossPool != null) {
bossPool.shutdown();
}
}
}
}