diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java index 79c5fda97a..231cf1d994 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java @@ -227,7 +227,7 @@ public class CombinedHttpHeaders extends DefaultHttpHeaders { return sb; } - private CharSequence commaSeparateEscapedValues(CharSequence currentValue, CharSequence value) { + private static CharSequence commaSeparateEscapedValues(CharSequence currentValue, CharSequence value) { return new StringBuilder(currentValue.length() + 1 + value.length()) .append(currentValue) .append(COMMA) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieEncoder.java index e68b7f52bc..c76264a90c 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieEncoder.java @@ -134,7 +134,7 @@ public final class ServerCookieEncoder extends CookieEncoder { * @param nameToLastIndex A map from cookie name to index of last cookie instance. * @return The encoded list with all but the last instance of a named cookie. */ - private List dedup(List encoded, Map nameToLastIndex) { + private static List dedup(List encoded, Map nameToLastIndex) { boolean[] isLastInstance = new boolean[encoded.size()]; for (int idx : nameToLastIndex.values()) { isLastInstance[idx] = true; diff --git a/common/src/main/java/io/netty/util/ConstantPool.java b/common/src/main/java/io/netty/util/ConstantPool.java index 881f1910e3..a05ab7e7c8 100644 --- a/common/src/main/java/io/netty/util/ConstantPool.java +++ b/common/src/main/java/io/netty/util/ConstantPool.java @@ -113,7 +113,7 @@ public abstract class ConstantPool> { throw new IllegalArgumentException(String.format("'%s' is already in use", name)); } - private String checkNotNullAndNotEmpty(String name) { + private static String checkNotNullAndNotEmpty(String name) { ObjectUtil.checkNotNull(name, "name"); if (name.isEmpty()) { diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java index d62073d83e..356c5c4434 100644 --- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java +++ b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java @@ -203,7 +203,7 @@ public abstract class SingleThreadEventExecutor extends AbstractScheduledEventEx return pollTaskFrom(taskQueue); } - protected final Runnable pollTaskFrom(Queue taskQueue) { + protected static Runnable pollTaskFrom(Queue taskQueue) { for (;;) { Runnable task = taskQueue.poll(); if (task == WAKEUP_TASK) { diff --git a/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/HelloWorldHttp2Handler.java b/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/HelloWorldHttp2Handler.java index 2aaedc539e..dee1cd7e16 100644 --- a/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/HelloWorldHttp2Handler.java +++ b/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/HelloWorldHttp2Handler.java @@ -85,7 +85,7 @@ public class HelloWorldHttp2Handler extends ChannelDuplexHandler { /** * Sends a "Hello World" DATA frame to the client. */ - private void sendResponse(ChannelHandlerContext ctx, ByteBuf payload) { + private static void sendResponse(ChannelHandlerContext ctx, ByteBuf payload) { // Send a frame for the response status Http2Headers headers = new DefaultHttp2Headers().status(OK.codeAsText()); ctx.write(new DefaultHttp2HeadersFrame(headers)); diff --git a/example/src/main/java/io/netty/example/http2/tiles/Http2RequestHandler.java b/example/src/main/java/io/netty/example/http2/tiles/Http2RequestHandler.java index e0fdc0ceae..6b05d92b77 100644 --- a/example/src/main/java/io/netty/example/http2/tiles/Http2RequestHandler.java +++ b/example/src/main/java/io/netty/example/http2/tiles/Http2RequestHandler.java @@ -106,11 +106,11 @@ public class Http2RequestHandler extends SimpleChannelInboundHandler sessionIdSet(Enumeration sessionIds) { + private static Set sessionIdSet(Enumeration sessionIds) { Set idSet = new HashSet(); byte[] id; while (sessionIds.hasMoreElements()) { diff --git a/transport/src/main/java/io/netty/channel/DefaultMaxBytesRecvByteBufAllocator.java b/transport/src/main/java/io/netty/channel/DefaultMaxBytesRecvByteBufAllocator.java index 65f7b068dc..9077551f88 100644 --- a/transport/src/main/java/io/netty/channel/DefaultMaxBytesRecvByteBufAllocator.java +++ b/transport/src/main/java/io/netty/channel/DefaultMaxBytesRecvByteBufAllocator.java @@ -173,7 +173,7 @@ public class DefaultMaxBytesRecvByteBufAllocator implements MaxBytesRecvByteBufA return new AbstractMap.SimpleEntry(maxBytesPerRead, maxBytesPerIndividualRead); } - private void checkMaxBytesPerReadPair(int maxBytesPerRead, int maxBytesPerIndividualRead) { + private static void checkMaxBytesPerReadPair(int maxBytesPerRead, int maxBytesPerIndividualRead) { if (maxBytesPerRead <= 0) { throw new IllegalArgumentException("maxBytesPerRead: " + maxBytesPerRead + " (expected: > 0)"); }