Make the code more compact. See #480

src/main/java/org/jboss/netty/channel/socket/nio/SocketReceiveBufferAllocator.java

@@ -38,26 +38,30 @@ final class SocketReceiveBufferAllocator {
 
     ByteBuffer get(int size) {
         if (buf == null) {
-            buf = ByteBuffer.allocateDirect(normalizeCapacity(size));
+            buf = newBuffer(size);
         } else if (buf.capacity() < size) {
-            exceedCount = 0;
+            buf = newBuffer(size);
-            ByteBufferUtil.destroy(buf);
+        } else if (((buf.capacity() / 100) * percentual) > size) {
-            buf = ByteBuffer.allocateDirect(normalizeCapacity(size));
-        } else if (buf.capacity() > size) {
-            if (((buf.capacity() / 100) * percentual) > size) {
             if (++exceedCount == maxExceedCount) {
-                    exceedCount = 0;
+                buf = newBuffer(size);
-                    ByteBufferUtil.destroy(buf);
+            } else {
-                    buf = ByteBuffer.allocateDirect(normalizeCapacity(size));
+                buf.clear();
             }
         } else {
             exceedCount = 0;
-            }
-        }
             buf.clear();
+        }
         return buf;
     }
 
+    private ByteBuffer newBuffer(int size) {
+        if (buf != null) {
+            exceedCount = 0;
+            ByteBufferUtil.destroy(buf);
+        }
+        return ByteBuffer.allocateDirect(normalizeCapacity(size));
+    }
+
     private static int normalizeCapacity(int capacity) {
         // Normalize to multiple of 1024
         int q = capacity >>> 10;