From 957154c00579649d7d49aa6b66522988dfdeb8cb Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Sat, 10 Nov 2012 01:08:18 +0900 Subject: [PATCH] Remove redundant no-arg constructors --- .../io/netty/handler/codec/http/HttpRequestEncoder.java | 6 ------ .../io/netty/handler/codec/http/HttpResponseEncoder.java | 6 ------ .../io/netty/handler/codec/spdy/DefaultSpdyNoOpFrame.java | 6 ------ .../netty/handler/codec/spdy/DefaultSpdySettingsFrame.java | 6 ------ .../main/java/io/netty/handler/codec/spdy/SpdySession.java | 3 --- .../codec/protobuf/ProtobufVarint32FrameDecoder.java | 6 ------ .../handler/codec/sctp/SctpMessageCompletionHandler.java | 5 ----- 7 files changed, 38 deletions(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java index f450c809da..7cc8bc1da1 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java @@ -25,12 +25,6 @@ import io.netty.util.CharsetUtil; */ public class HttpRequestEncoder extends HttpMessageEncoder { - /** - * Creates a new instance. - */ - public HttpRequestEncoder() { - } - @Override protected void encodeInitialLine(ByteBuf buf, HttpMessage message) throws Exception { HttpRequest request = (HttpRequest) message; diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java index 141b41d8e1..96e4814c83 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java @@ -25,12 +25,6 @@ import io.netty.util.CharsetUtil; */ public class HttpResponseEncoder extends HttpMessageEncoder { - /** - * Creates a new instance. - */ - public HttpResponseEncoder() { - } - @Override protected void encodeInitialLine(ByteBuf buf, HttpMessage message) throws Exception { HttpResponse response = (HttpResponse) message; diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdyNoOpFrame.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdyNoOpFrame.java index 116c5098a8..4f75c0382a 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdyNoOpFrame.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdyNoOpFrame.java @@ -20,12 +20,6 @@ package io.netty.handler.codec.spdy; */ public class DefaultSpdyNoOpFrame implements SpdyNoOpFrame { - /** - * Creates a new instance. - */ - public DefaultSpdyNoOpFrame() { - } - @Override public String toString() { return getClass().getSimpleName(); diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdySettingsFrame.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdySettingsFrame.java index a3d9f709bf..17b1b5000e 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdySettingsFrame.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/DefaultSpdySettingsFrame.java @@ -29,12 +29,6 @@ public class DefaultSpdySettingsFrame implements SpdySettingsFrame { private boolean clear; private final Map settingsMap = new TreeMap(); - /** - * Creates a new instance. - */ - public DefaultSpdySettingsFrame() { - } - @Override public Set getIds() { return settingsMap.keySet(); diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySession.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySession.java index 727b2a9ec0..5c3b674cec 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySession.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySession.java @@ -29,9 +29,6 @@ final class SpdySession { private final Map activeStreams = new ConcurrentHashMap(); - SpdySession() { - } - int numActiveStreams() { return activeStreams.size(); } diff --git a/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32FrameDecoder.java b/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32FrameDecoder.java index 6e0e0d5ea4..a71d9af88f 100644 --- a/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32FrameDecoder.java +++ b/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32FrameDecoder.java @@ -42,12 +42,6 @@ public class ProtobufVarint32FrameDecoder extends ByteToMessageDecoder { // TODO maxFrameLength + safe skip + fail-fast option // (just like LengthFieldBasedFrameDecoder) - /** - * Creates a new instance. - */ - public ProtobufVarint32FrameDecoder() { - } - @Override public Object decode(ChannelHandlerContext ctx, ByteBuf in) throws Exception { in.markReaderIndex(); diff --git a/codec/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHandler.java b/codec/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHandler.java index afdc890567..2914e57403 100644 --- a/codec/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHandler.java +++ b/codec/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHandler.java @@ -28,11 +28,6 @@ import java.util.Map; public class SctpMessageCompletionHandler extends ChannelInboundMessageHandlerAdapter { private Map fragments = new HashMap(); - /** - */ - public SctpMessageCompletionHandler() { - } - @Override public void messageReceived(ChannelHandlerContext ctx, SctpMessage msg) throws Exception {