andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use SocketReceiveBufferAllocator to allocate the ByteBuffer which is used to read from the DatagramChannel. See #483

Browse Source
This commit is contained in:
Norman Maurer 2012-07-31 20:31:02 +02:00 committed by Norman Maurer
parent 7dcae71b09
commit 95cf6a4a71
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramWorker.java
View File

@ -41,6 +41,8 @@ import org.jboss.netty.channel.ReceiveBufferSizePredictor;
*/
public class NioDatagramWorker extends AbstractNioWorker {
private final SocketReceiveBufferAllocator bufferAllocator = new SocketReceiveBufferAllocator();
/**
* Sole constructor.
*
@ -67,13 +69,9 @@ public class NioDatagramWorker extends AbstractNioWorker {
channel.getConfig().getReceiveBufferSizePredictor();
final ChannelBufferFactory bufferFactory = channel.getConfig().getBufferFactory();
final DatagramChannel nioChannel = (DatagramChannel) key.channel();
final int predictedRecvBufSize = predictor.nextReceiveBufferSize();
// Allocating a non-direct buffer with a max udp packge size.
// Would using a direct buffer be more efficient or would this negatively
// effect performance, as direct buffer allocation has a higher upfront cost
// where as a ByteBuffer is heap allocated.
final ByteBuffer byteBuffer = ByteBuffer.allocate(
predictor.nextReceiveBufferSize()).order(bufferFactory.getDefaultOrder());
final ByteBuffer byteBuffer = bufferAllocator.get(predictedRecvBufSize).order(bufferFactory.getDefaultOrder());
boolean failure = true;
SocketAddress remoteAddress = null;