Make a member field final wherever possible

codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskAttribute.java

@@ -30,9 +30,9 @@ public class DiskAttribute extends AbstractDiskHttpData implements Attribute {
 
     public static boolean deleteOnExitTemporaryFile = true;
 
-    public static String prefix = "Attr_";
+    public static final String prefix = "Attr_";
 
-    public static String postfix = ".att";
+    public static final String postfix = ".att";
 
     /**
      * Constructor used for huge Attribute

codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskFileUpload.java

@@ -28,9 +28,9 @@ public class DiskFileUpload extends AbstractDiskHttpData implements FileUpload {
 
     public static boolean deleteOnExitTemporaryFile = true;
 
-    public static String prefix = "FUp_";
+    public static final String prefix = "FUp_";
 
-    public static String postfix = ".tmp";
+    public static final String postfix = ".tmp";
 
     private String filename;
 

codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java

@@ -25,7 +25,7 @@ import java.nio.charset.Charset;
  */
 final class HttpPostBodyUtil {
 
-    public static int chunkSize = 8096;
+    public static final int chunkSize = 8096;
     /**
      * HTTP content disposition header name.
      */

codec-http/src/main/java/io/netty/handler/codec/http/multipart/InternalAttribute.java

@@ -23,7 +23,7 @@ import java.util.List;
  * (like Multipart Mixed mode)
  */
 public class InternalAttribute implements InterfaceHttpData {
-    protected List<String> value = new ArrayList<String>();
+    protected final List<String> value = new ArrayList<String>();
 
     @Override
     public HttpDataType getHttpDataType() {

common/src/main/java/io/netty/util/internal/jzlib/Deflate.java

@@ -194,22 +194,22 @@ final class Deflate {
     int good_match;
     // Stop searching when current match exceeds this
     int nice_match;
-    short[] dyn_ltree; // literal and length tree
+    final short[] dyn_ltree; // literal and length tree
-    short[] dyn_dtree; // distance tree
+    final short[] dyn_dtree; // distance tree
-    short[] bl_tree; // Huffman tree for bit lengths
+    final short[] bl_tree; // Huffman tree for bit lengths
-    Tree l_desc = new Tree(); // desc for literal tree
+    final Tree l_desc = new Tree(); // desc for literal tree
-    Tree d_desc = new Tree(); // desc for distance tree
+    final Tree d_desc = new Tree(); // desc for distance tree
-    Tree bl_desc = new Tree(); // desc for bit length tree
+    final Tree bl_desc = new Tree(); // desc for bit length tree
     // number of codes at each bit length for an optimal tree
-    short[] bl_count = new short[JZlib.MAX_BITS + 1];
+    final short[] bl_count = new short[JZlib.MAX_BITS + 1];
     // heap used to build the Huffman trees
-    int[] heap = new int[2 * JZlib.L_CODES + 1];
+    final int[] heap = new int[2 * JZlib.L_CODES + 1];
     int heap_len; // number of elements in the heap
     int heap_max; // element of largest frequency
     // The sons of heap[n] are heap[2*n] and heap[2*n+1]. heap[0] is not used.
     // The same heap array is used to build all trees.
     // Depth of each subtree used as tie breaker for trees of equal frequency
-    byte[] depth = new byte[2 * JZlib.L_CODES + 1];
+    final byte[] depth = new byte[2 * JZlib.L_CODES + 1];
     int l_buf; // index for literals or lengths */
     // Size of match buffer for literals/lengths.  There are 4 reasons for
     // limiting lit_bufsize to 64K:

transport/src/test/java/io/netty/channel/local/LocalTransportThreadModelTest2.java

@@ -131,7 +131,7 @@ public class LocalTransportThreadModelTest2 {
 
         public volatile ChannelFuture lastWriteFuture;
 
-        public AtomicInteger count = new AtomicInteger(0);
+        public final AtomicInteger count = new AtomicInteger(0);
 
         public LocalHander(String name) {
             this.name = name;