From 97825598d2fd0df54f0686d6577a162e7f044b80 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Fri, 4 Jul 2014 16:11:38 +0900 Subject: [PATCH] Fix another buffer leaks in JsonObjectDecoderTest --- .../codec/json/JsonObjectDecoderTest.java | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java index be3598dc34..08ece60917 100644 --- a/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java +++ b/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java @@ -113,7 +113,11 @@ public class JsonObjectDecoderTest { @Test(expected = CorruptedFrameException.class) public void testNonJsonContent1() { EmbeddedChannel ch = new EmbeddedChannel(new JsonObjectDecoder()); - ch.writeInbound(Unpooled.copiedBuffer(" b [1,2,3]", CharsetUtil.UTF_8)); + try { + ch.writeInbound(Unpooled.copiedBuffer(" b [1,2,3]", CharsetUtil.UTF_8)); + } finally { + assertFalse(ch.finish()); + } fail(); } @@ -127,7 +131,11 @@ public class JsonObjectDecoderTest { assertEquals("[1,2,3]", res.toString(CharsetUtil.UTF_8)); res.release(); - ch.writeInbound(Unpooled.copiedBuffer(" a {\"key\" : 10}", CharsetUtil.UTF_8)); + try { + ch.writeInbound(Unpooled.copiedBuffer(" a {\"key\" : 10}", CharsetUtil.UTF_8)); + } finally { + assertFalse(ch.finish()); + } fail(); } @@ -135,7 +143,11 @@ public class JsonObjectDecoderTest { @Test (expected = TooLongFrameException.class) public void testMaxObjectLength() { EmbeddedChannel ch = new EmbeddedChannel(new JsonObjectDecoder(6)); - ch.writeInbound(Unpooled.copiedBuffer("[2,4,5]", CharsetUtil.UTF_8)); + try { + ch.writeInbound(Unpooled.copiedBuffer("[2,4,5]", CharsetUtil.UTF_8)); + } finally { + assertFalse(ch.finish()); + } fail(); }