andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add the URL of the wiki for easier troubleshooting

Browse Source 
Motivation:

When a user sees an error message, sometimes he or she does not know
what exactly he or she has to do to fix the problem.

Modifications:

Log the URL of the wiki pages that might help the user troubleshoot.

Result:

We are more friendly.
This commit is contained in:
Trustin Lee 2015-01-08 12:43:03 +09:00
parent 2c3f4a374a
commit 98731a51c8
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/src/main/java/io/netty/util/ResourceLeakDetector.java
View File

@ -238,11 +238,13 @@ public final class ResourceLeakDetector<T> {
logger.error("LEAK: {}.release() was not called before it's garbage-collected. " + logger.error("LEAK: {}.release() was not called before it's garbage-collected. " +
"Enable advanced leak reporting to find out where the leak occurred. " + "Enable advanced leak reporting to find out where the leak occurred. " +
"To enable advanced leak reporting, " + "To enable advanced leak reporting, " +
"specify the JVM option '-D{}={}' or call {}.setLevel()", "specify the JVM option '-D{}={}' or call {}.setLevel() " +
"See http://netty.io/wiki/reference-counted-objects.html for more information.",
resourceType, PROP_LEVEL, Level.ADVANCED.name().toLowerCase(), simpleClassName(this)); resourceType, PROP_LEVEL, Level.ADVANCED.name().toLowerCase(), simpleClassName(this));
} else { } else {
logger.error( logger.error(
"LEAK: {}.release() was not called before it's garbage-collected.{}", "LEAK: {}.release() was not called before it's garbage-collected. " +
"See http://netty.io/wiki/reference-counted-objects.html for more information.{}",
resourceType, records); resourceType, records);
} }
} }
@ -326,6 +328,7 @@ public final class ResourceLeakDetector<T> {
return false; return false;
} }
@Override
public String toString() { public String toString() {
if (creationRecord == null) { if (creationRecord == null) {
return ""; return "";

3
handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
View File

@ -62,7 +62,8 @@ public final class OpenSsl {
cause = t; cause = t;
logger.debug( logger.debug(
"Failed to load netty-tcnative; " + "Failed to load netty-tcnative; " +
OpenSslEngine.class.getSimpleName() + " will be unavailable.", t); OpenSslEngine.class.getSimpleName() + " will be unavailable. " +
"See http://netty.io/wiki/forked-tomcat-native.html for more information.", t);
} }
} }