andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Just tiny optimization to avoid object creation

Browse Source
This commit is contained in:
Norman Maurer 2013-07-12 08:23:01 +02:00
parent c38db2afe3
commit 98c6a5810a
1 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
common/src/main/java/io/netty/util/internal/RecyclableArrayList.java
View File

@ -21,6 +21,8 @@ import io.netty.util.Recycler.Handle;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.RandomAccess;
/**
* A simple list that holds the output of a codec.
@ -67,22 +69,33 @@ public final class RecyclableArrayList extends ArrayList<Object> {
@Override
public boolean addAll(Collection<?> c) {
for (Object element: c) {
if (element == null) {
throw new IllegalArgumentException("c contains null values");
}
}
checkNullElements(c);
return super.addAll(c);
}
@Override
public boolean addAll(int index, Collection<?> c) {
for (Object element: c) {
if (element == null) {
throw new IllegalArgumentException("c contains null values");
checkNullElements(c);
return super.addAll(index, c);
}
private void checkNullElements(Collection<?> c) {
if (c instanceof RandomAccess && c instanceof List) {
// produce less garbage
List<?> list = (List<?>) c;
int size = list.size();
for (int i = 0; i < size; i++) {
if (list.get(i) == null) {
throw new IllegalArgumentException("c contains null values");
}
}
} else {
for (Object element: c) {
if (element == null) {
throw new IllegalArgumentException("c contains null values");
}
}
}
return super.addAll(index, c);
}
@Override