andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Catch+fire Exceptions thrown from SniHandler's select() method

Browse Source 
Motivation

Give the user the ability to back out from SNI negoations.

Modifications

Put a try-catch around the select() call and re-fire any caught Exceptions.

Result

Fixes #5787
This commit is contained in:
Roger Kapsi 2016-09-16 12:26:12 -04:00 committed by Norman Maurer
parent 8d6f0a3ce4
commit 9a18159bfe
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
handler/src/main/java/io/netty/handler/ssl/SniHandler.java
View File

@ -244,8 +244,12 @@ public class SniHandler extends ByteToMessageDecoder implements ChannelOutboundH
final String hostname = in.toString(offset, serverNameLength, final String hostname = in.toString(offset, serverNameLength,
CharsetUtil.UTF_8); CharsetUtil.UTF_8);
select(ctx, IDN.toASCII(hostname, try {
IDN.ALLOW_UNASSIGNED).toLowerCase(Locale.US)); select(ctx, IDN.toASCII(hostname,
IDN.ALLOW_UNASSIGNED).toLowerCase(Locale.US));
} catch (Throwable t) {
ctx.fireExceptionCaught(t);
}
return; return;
} else { } else {
// invalid enum value // invalid enum value