From 9ed2f01853d82940b42c795eb541046872c3086b Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Mon, 2 May 2016 14:23:41 -0700 Subject: [PATCH] Revert "Returns after encoding each message not do check following instance types" Motivation: This reverts commit 3405aee2abf990d1f6078eb27da1b0035ab34769. This commit introduces a bug and the encoder no longer encodes FullMemcacheMessage objects correctly. Modifications: - Revert commit Result: Fixes https://github.com/netty/netty/issues/5197 --- .../handler/codec/memcache/AbstractMemcacheObjectEncoder.java | 1 - 1 file changed, 1 deletion(-) diff --git a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java index b209fcd110..4248f81210 100644 --- a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java +++ b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java @@ -45,7 +45,6 @@ public abstract class AbstractMemcacheObjectEncoder e @SuppressWarnings({ "unchecked", "CastConflictsWithInstanceof" }) final M m = (M) msg; out.add(encodeMessage(ctx, m)); - return; } if (msg instanceof MemcacheContent || msg instanceof ByteBuf || msg instanceof FileRegion) {