andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix ByteBufUtilBenchmark on utf8 encodings.

Browse Source 
Motivation
----------
The performance tests for utf8 also used the getBytes on ASCII,
which is incorrect and also provides different performance numbers.

Modifications
-------------
Use CharsetUtil.UTF_8 instead of US_ASCII for the getBytes calls.

Result
------
Accurate and semantically correct benchmarking results on utf8
comparisons.
This commit is contained in:
Michael Nitschinger 2014-12-30 17:19:08 +01:00 committed by Trustin Lee
parent 4973d06254
commit 9fc95803da
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
microbench/src/test/java/io/netty/microbench/buffer/ByteBufUtilBenchmark.java
View File

@ -32,7 +32,8 @@ import org.openjdk.jmh.annotations.Warmup;
@State(Scope.Benchmark) @State(Scope.Benchmark)
@Warmup(iterations = 10) @Warmup(iterations = 10)
@Measurement(iterations = 25) @Measurement(iterations = 25)
public class ByteBufUtilBenchmark extends AbstractMicrobenchmark { public class
ByteBufUtilBenchmark extends AbstractMicrobenchmark {
private ByteBuf buffer; private ByteBuf buffer;
private ByteBuf wrapped; private ByteBuf wrapped;
@ -120,13 +121,13 @@ public class ByteBufUtilBenchmark extends AbstractMicrobenchmark {
@Benchmark @Benchmark
public void writeUtf8StringViaArray() { public void writeUtf8StringViaArray() {
buffer.resetWriterIndex(); buffer.resetWriterIndex();
buffer.writeBytes(utf8.getBytes(CharsetUtil.US_ASCII)); buffer.writeBytes(utf8.getBytes(CharsetUtil.UTF_8));
} }
@Benchmark @Benchmark
public void writeUtf8StringViaArrayWrapped() { public void writeUtf8StringViaArrayWrapped() {
wrapped.resetWriterIndex(); wrapped.resetWriterIndex();
wrapped.writeBytes(utf8.getBytes(CharsetUtil.US_ASCII)); wrapped.writeBytes(utf8.getBytes(CharsetUtil.UTF_8));
} }
@Benchmark @Benchmark
@ -144,13 +145,13 @@ public class ByteBufUtilBenchmark extends AbstractMicrobenchmark {
@Benchmark @Benchmark
public void writeUtf8ViaArray() { public void writeUtf8ViaArray() {
buffer.resetWriterIndex(); buffer.resetWriterIndex();
buffer.writeBytes(utf8Sequence.toString().getBytes(CharsetUtil.US_ASCII)); buffer.writeBytes(utf8Sequence.toString().getBytes(CharsetUtil.UTF_8));
} }
@Benchmark @Benchmark
public void writeUtf8ViaArrayWrapped() { public void writeUtf8ViaArrayWrapped() {
wrapped.resetWriterIndex(); wrapped.resetWriterIndex();
wrapped.writeBytes(utf8Sequence.toString().getBytes(CharsetUtil.US_ASCII)); wrapped.writeBytes(utf8Sequence.toString().getBytes(CharsetUtil.UTF_8));
} }
@Benchmark @Benchmark