From a123c495e1b789f906f59b0227c6ad920460a4a4 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 20 Apr 2015 09:10:14 +0200 Subject: [PATCH] Revert "Add another test case for channelReadComplete() suppression" This reverts commit daa04cb4f10050919b3aa4df89b0ea6aeebe335b. --- .../channel/DefaultChannelPipelineTest.java | 38 ------------------- 1 file changed, 38 deletions(-) diff --git a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java b/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java index 9f41a8ea1d..e36d171fd4 100644 --- a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java +++ b/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java @@ -634,44 +634,6 @@ public class DefaultChannelPipelineTest { } } - /** - * {@link ChannelInboundHandler#channelReadComplete(ChannelHandlerContext)} should not be suppressed - * when a handler has just been added and thus had no chance to get the previous - * {@link ChannelInboundHandler#channelRead(ChannelHandlerContext, Object)}. - */ - @Test - public void testProhibitChannelReadCompleteSuppression() throws Exception { - final AtomicInteger readComplete = new AtomicInteger(); - - EmbeddedChannel ch = new EmbeddedChannel(new ChannelInboundHandlerAdapter() { - @Override - public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception { - ctx.fireChannelRead(msg); - - // Add a new handler *after* channelRead() is triggered, so that - // the new handler does not handle channelRead() at all. - ctx.pipeline().addAfter(ctx.name(), "newHandler", new ChannelInboundHandlerAdapter() { - @Override - public void channelReadComplete(ChannelHandlerContext ctx) throws Exception { - readComplete.incrementAndGet(); - } - }); - } - - @Override - public void channelReadComplete(ChannelHandlerContext ctx) throws Exception { - ctx.fireChannelReadComplete(); - } - }); - - ChannelPipeline p = ch.pipeline(); - p.fireChannelRead(Boolean.TRUE); - p.fireChannelReadComplete(); - ch.finish(); - - assertEquals(1, readComplete.get()); - } - @Test public void testChannelReadTriggered() { final AtomicInteger read1 = new AtomicInteger();