Fix overriden method not called in TrafficShaping
Motivation: handlerAdded and handlerRemoved were overriden but super was never called, while it should. Also add one missing information in the toString method. Modifications: Add the super corresponding call, and add checkInterval to the toString() method Result; super method calls are correctly passed to the super implementation part.
This commit is contained in:
parent
8988b3f4c0
commit
a25c585f39
@ -411,9 +411,9 @@ public abstract class AbstractTrafficShapingHandler extends ChannelDuplexHandler
|
||||
|
||||
@Override
|
||||
public String toString() {
|
||||
return "TrafficShaping with Write Limit: " + writeLimit +
|
||||
" Read Limit: " + readLimit + " and Counter: " +
|
||||
(trafficCounter != null? trafficCounter.toString() : "none");
|
||||
return "TrafficShaping with Write Limit: " + writeLimit + " Read Limit: " + readLimit +
|
||||
" CheckInterval: " + checkInterval + " and Counter: "
|
||||
+ (trafficCounter != null ? trafficCounter.toString() : "none");
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -117,6 +117,7 @@ public class ChannelTrafficShapingHandler extends AbstractTrafficShapingHandler
|
||||
ctx.channel().hashCode(), checkInterval);
|
||||
setTrafficCounter(trafficCounter);
|
||||
trafficCounter.start();
|
||||
super.handlerAdded(ctx);
|
||||
}
|
||||
|
||||
@Override
|
||||
@ -130,6 +131,7 @@ public class ChannelTrafficShapingHandler extends AbstractTrafficShapingHandler
|
||||
}
|
||||
}
|
||||
messagesQueue.clear();
|
||||
super.handlerRemoved(ctx);
|
||||
}
|
||||
|
||||
private static final class ToSend {
|
||||
|
@ -172,6 +172,7 @@ public class GlobalTrafficShapingHandler extends AbstractTrafficShapingHandler {
|
||||
Integer key = ctx.channel().hashCode();
|
||||
List<ToSend> mq = new LinkedList<ToSend>();
|
||||
messagesQueues.put(key, mq);
|
||||
super.handlerAdded(ctx);
|
||||
}
|
||||
|
||||
@Override
|
||||
@ -186,6 +187,7 @@ public class GlobalTrafficShapingHandler extends AbstractTrafficShapingHandler {
|
||||
}
|
||||
mq.clear();
|
||||
}
|
||||
super.handlerRemoved(ctx);
|
||||
}
|
||||
|
||||
private static final class ToSend {
|
||||
|
Loading…
Reference in New Issue
Block a user