andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix StackOverflowError in LocalEcho.doBeginRead() when the peer channel keeps writing data

Browse Source 
- Fixes #1380
This commit is contained in:
Trustin Lee 2013-05-24 11:54:44 +09:00
parent 5398792ffa
commit a3b4cdd614
1 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
transport/src/main/java/io/netty/channel/local/LocalChannel.java
View File

@ -43,7 +43,24 @@ public class LocalChannel extends AbstractChannel {
private static final ChannelMetadata METADATA = new ChannelMetadata(BufType.MESSAGE, false);
private static final int MAX_READER_STACK_DEPTH = 8;
private static final ThreadLocal<Integer> READER_STACK_DEPTH = new ThreadLocal<Integer>() {
@Override
protected Integer initialValue() {
return 0;
}
};
private final ChannelConfig config = new DefaultChannelConfig(this);
private final Runnable readTask = new Runnable() {
@Override
public void run() {
ChannelPipeline pipeline = pipeline();
pipeline.fireInboundBufferUpdated();
pipeline.fireChannelReadSuspended();
}
};
private final Runnable shutdownHook = new Runnable() {
@Override
public void run() {
@ -225,8 +242,18 @@ public class LocalChannel extends AbstractChannel {
return;
}
pipeline.fireInboundBufferUpdated();
pipeline.fireChannelReadSuspended();
final Integer stackDepth = READER_STACK_DEPTH.get();
if (stackDepth < MAX_READER_STACK_DEPTH) {
READER_STACK_DEPTH.set(stackDepth + 1);
try {
pipeline.fireInboundBufferUpdated();
pipeline.fireChannelReadSuspended();
} finally {
READER_STACK_DEPTH.set(stackDepth);
}
} else {
eventLoop().execute(readTask);
}
}
@Override