andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Reduce the number of unnecessary Selector.wakeup() / Fix a bug where channelReadSuspended() generates garbage

Browse Source
This commit is contained in:
Trustin Lee 2013-02-09 01:05:33 +09:00
parent 801f563e80
commit a4c66dc282
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java
View File

@ -1023,7 +1023,7 @@ final class DefaultChannelHandlerContext extends DefaultAttributeMap implements
public void fireChannelReadSuspended() { public void fireChannelReadSuspended() {
final DefaultChannelHandlerContext next = findContextInbound(); final DefaultChannelHandlerContext next = findContextInbound();
EventExecutor executor = next.executor(); EventExecutor executor = next.executor();
if (prev != null && executor.inEventLoop()) { if (executor.inEventLoop()) {
next.invokeChannelReadSuspended(); next.invokeChannelReadSuspended();
} else { } else {
Runnable task = next.invokeChannelReadSuspendedTask; Runnable task = next.invokeChannelReadSuspendedTask;

6
transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
View File

@ -295,10 +295,10 @@ public final class NioEventLoop extends SingleThreadEventLoop {
cancelledKeys = 0; cancelledKeys = 0;
runAllTasks(); processSelectedKeys();
selector = this.selector; selector = this.selector;
processSelectedKeys(); runAllTasks();
selector = this.selector; selector = this.selector;
if (isShutdown()) { if (isShutdown()) {
@ -502,7 +502,7 @@ public final class NioEventLoop extends SingleThreadEventLoop {
@Override @Override
protected void wakeup(boolean inEventLoop) { protected void wakeup(boolean inEventLoop) {
if (wakenUp.compareAndSet(false, true)) { if (!inEventLoop && wakenUp.compareAndSet(false, true)) {
selector.wakeup(); selector.wakeup();
} }
} }