andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

use enum for state in LocalChannel

Browse Source
This commit is contained in:
Bill Gallagher 2013-10-01 15:15:48 -04:00 committed by Norman Maurer
parent f80109f423
commit a5220198ba
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
transport/src/main/java/io/netty/channel/local/LocalChannel.java
View File

@ -42,6 +42,8 @@ import java.util.Queue;
*/ */
public class LocalChannel extends AbstractChannel { public class LocalChannel extends AbstractChannel {
private enum State { OPEN, BOUND, CONNECTED, CLOSED }
private static final ChannelMetadata METADATA = new ChannelMetadata(false); private static final ChannelMetadata METADATA = new ChannelMetadata(false);
private static final int MAX_READER_STACK_DEPTH = 8; private static final int MAX_READER_STACK_DEPTH = 8;
@ -76,7 +78,8 @@ public class LocalChannel extends AbstractChannel {
} }
}; };
private volatile int state; // 0 - open, 1 - bound, 2 - connected, 3 - closed
private volatile State state;
private volatile LocalChannel peer; private volatile LocalChannel peer;
private volatile LocalAddress localAddress; private volatile LocalAddress localAddress;
private volatile LocalAddress remoteAddress; private volatile LocalAddress remoteAddress;
@ -121,12 +124,12 @@ public class LocalChannel extends AbstractChannel {
@Override @Override
public boolean isOpen() { public boolean isOpen() {
return state < 3; return state != State.CLOSED;
} }
@Override @Override
public boolean isActive() { public boolean isActive() {
return state == 2; return state == State.CONNECTED;
} }
@Override @Override
@ -152,10 +155,10 @@ public class LocalChannel extends AbstractChannel {
@Override @Override
protected void doRegister() throws Exception { protected void doRegister() throws Exception {
if (peer != null) { if (peer != null) {
state = 2; state = State.CONNECTED;
peer.remoteAddress = parent() == null ? null : parent().localAddress(); peer.remoteAddress = parent() == null ? null : parent().localAddress();
peer.state = 2; peer.state = State.CONNECTED;
// Always call peer.eventLoop().execute() even if peer.eventLoop().inEventLoop() is true. // Always call peer.eventLoop().execute() even if peer.eventLoop().inEventLoop() is true.
// This ensures that if both channels are on the same event loop, the peer's channelActive // This ensures that if both channels are on the same event loop, the peer's channelActive
@ -177,7 +180,7 @@ public class LocalChannel extends AbstractChannel {
this.localAddress = this.localAddress =
LocalChannelRegistry.register(this, this.localAddress, LocalChannelRegistry.register(this, this.localAddress,
localAddress); localAddress);
state = 1; state = State.BOUND;
} }
@Override @Override
@ -187,7 +190,7 @@ public class LocalChannel extends AbstractChannel {
@Override @Override
protected void doClose() throws Exception { protected void doClose() throws Exception {
if (state <= 2) { if (state != State.CLOSED) {
// Update all internal state before the closeFuture is notified. // Update all internal state before the closeFuture is notified.
if (localAddress != null) { if (localAddress != null) {
if (parent() == null) { if (parent() == null) {
@ -195,7 +198,7 @@ public class LocalChannel extends AbstractChannel {
} }
localAddress = null; localAddress = null;
} }
state = 3; state = State.CLOSED;
} }
final LocalChannel peer = this.peer; final LocalChannel peer = this.peer;
@ -257,10 +260,11 @@ public class LocalChannel extends AbstractChannel {
@Override @Override
protected void doWrite(ChannelOutboundBuffer in) throws Exception { protected void doWrite(ChannelOutboundBuffer in) throws Exception {
if (state < 2) { switch (state) {
case OPEN:
case BOUND:
throw new NotYetConnectedException(); throw new NotYetConnectedException();
} case CLOSED:
if (state > 2) {
throw new ClosedChannelException(); throw new ClosedChannelException();
} }
@ -322,7 +326,7 @@ public class LocalChannel extends AbstractChannel {
return; return;
} }
if (state == 2) { if (state == State.CONNECTED) {
Exception cause = new AlreadyConnectedException(); Exception cause = new AlreadyConnectedException();
promise.setFailure(cause); promise.setFailure(cause);
pipeline().fireExceptionCaught(cause); pipeline().fireExceptionCaught(cause);
@ -335,7 +339,7 @@ public class LocalChannel extends AbstractChannel {
connectPromise = promise; connectPromise = promise;
if (state != 1) { if (state != State.BOUND) {
// Not bound yet and no localAddress specified - get one. // Not bound yet and no localAddress specified - get one.
if (localAddress == null) { if (localAddress == null) {
localAddress = new LocalAddress(LocalChannel.this); localAddress = new LocalAddress(LocalChannel.this);