andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed issue: NETTY-373 Deadlock in ChunkedWriteHandler on channel

Browse Source 
close.

* channelInterestChanged event is not fired anymore when a socket is
closing because it is unnecessary
This commit is contained in:
Trustin Lee 2011-02-01 11:43:16 +09:00
parent d8ff180610
commit a5aef71218
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramChannel.java
View File

@ -298,7 +298,7 @@ class NioDatagramChannel extends AbstractChannel
if (newWriteBufferSize == 0 || newWriteBufferSize < lowWaterMark) { if (newWriteBufferSize == 0 || newWriteBufferSize < lowWaterMark) {
if (newWriteBufferSize + messageSize >= lowWaterMark) { if (newWriteBufferSize + messageSize >= lowWaterMark) {
highWaterMarkCounter.decrementAndGet(); highWaterMarkCounter.decrementAndGet();
if (!notifying.get()) { if (isBound() && !notifying.get()) {
notifying.set(Boolean.TRUE); notifying.set(Boolean.TRUE);
fireChannelInterestChanged(NioDatagramChannel.this); fireChannelInterestChanged(NioDatagramChannel.this);
notifying.set(Boolean.FALSE); notifying.set(Boolean.FALSE);

2
src/main/java/org/jboss/netty/channel/socket/nio/NioSocketChannel.java
View File

@ -242,7 +242,7 @@ class NioSocketChannel extends AbstractChannel
if (newWriteBufferSize == 0 || newWriteBufferSize < lowWaterMark) { if (newWriteBufferSize == 0 || newWriteBufferSize < lowWaterMark) {
if (newWriteBufferSize + messageSize >= lowWaterMark) { if (newWriteBufferSize + messageSize >= lowWaterMark) {
highWaterMarkCounter.decrementAndGet(); highWaterMarkCounter.decrementAndGet();
if (!notifying.get()) { if (isConnected() && !notifying.get()) {
notifying.set(Boolean.TRUE); notifying.set(Boolean.TRUE);
fireChannelInterestChanged(NioSocketChannel.this); fireChannelInterestChanged(NioSocketChannel.this);
notifying.set(Boolean.FALSE); notifying.set(Boolean.FALSE);