EPOLL Shutdown and Half Closed

Motivation:
The EPOLL module was not completly respecting the half closed state. It may have missed events, or procssed events when it should not have due to checking isOpen instead of the appropriate shutdown state.

Modifications:
- use FileDescriptor's isShutdown* methods instead of isOpen to check for processing events.

Result:
Half closed code in EPOLL module is more correct.

transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java

@@ -25,7 +25,6 @@ import io.netty.channel.ChannelMetadata;
 import io.netty.channel.ChannelOption;
 import io.netty.channel.EventLoop;
 import io.netty.channel.socket.ChannelInputShutdownEvent;
-import io.netty.channel.unix.FileDescriptor;
 import io.netty.channel.unix.Socket;
 import io.netty.channel.unix.UnixChannel;
 import io.netty.util.ReferenceCountUtil;
@@ -45,7 +44,6 @@ abstract class AbstractEpollChannel extends AbstractChannel implements UnixChann
     protected int flags = Native.EPOLLET;
 
     protected volatile boolean active;
-    private volatile boolean inputShutdown;
 
     AbstractEpollChannel(Socket fd, int flag) {
         this(null, fd, flag, false);
@@ -97,15 +95,14 @@ abstract class AbstractEpollChannel extends AbstractChannel implements UnixChann
 
     @Override
     protected void doClose() throws Exception {
-        boolean active = this.active;
         this.active = false;
-        FileDescriptor fd = fileDescriptor;
+        Socket fd = fileDescriptor;
         try {
             // deregister from epoll now and shutdown the socket.
             doDeregister();
-            if (active) {
+            if (!fd.isShutdown()) {
                 try {
-                    fd().shutdown(true, true);
+                    fd().shutdown();
                 } catch (IOException ignored) {
                     // The FD will be closed, so if shutdown fails there is nothing we can do.
                 }
@@ -182,10 +179,6 @@ abstract class AbstractEpollChannel extends AbstractChannel implements UnixChann
         loop.add(this);
     }
 
-    protected final boolean isInputShutdown0() {
-        return inputShutdown;
-    }
-
     @Override
     protected abstract AbstractEpollUnsafe newUnsafe();
 
@@ -352,21 +345,18 @@ abstract class AbstractEpollChannel extends AbstractChannel implements UnixChann
          * Shutdown the input side of the channel.
          */
         void shutdownInput() {
-            if (!inputShutdown) { // Best effort check on volatile variable to prevent multiple shutdowns
+            if (!fd().isInputShutdown()) {
-                inputShutdown = true;
+                if (Boolean.TRUE.equals(config().getOption(ChannelOption.ALLOW_HALF_CLOSURE))) {
-                if (isOpen()) {
+                    try {
-                    if (Boolean.TRUE.equals(config().getOption(ChannelOption.ALLOW_HALF_CLOSURE))) {
+                        fd().shutdown(true, false);
-                        try {
+                        clearEpollIn0();
-                            fd().shutdown(true, false);
+                        pipeline().fireUserEventTriggered(ChannelInputShutdownEvent.INSTANCE);
-                            clearEpollIn0();
+                    } catch (IOException e) {
-                            pipeline().fireUserEventTriggered(ChannelInputShutdownEvent.INSTANCE);
+                        pipeline().fireExceptionCaught(e);
-                        } catch (IOException e) {
-                            pipeline().fireExceptionCaught(e);
-                            close(voidPromise());
-                        }
-                    } else {
                         close(voidPromise());
                     }
+                } else {
+                    close(voidPromise());
                 }
             }
         }
@@ -386,6 +376,9 @@ abstract class AbstractEpollChannel extends AbstractChannel implements UnixChann
          * Called once a EPOLLOUT event is ready to be processed
          */
         void epollOutReady() {
+            if (fd().isOutputShutdown()) {
+                return;
+            }
             // directly call super.flush0() to force a flush now
             super.flush0();
         }

transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollServerChannel.java

@@ -100,6 +100,9 @@ public abstract class AbstractEpollServerChannel extends AbstractEpollChannel im
         @Override
         void epollInReady() {
             assert eventLoop().inEventLoop();
+            if (fd().isInputShutdown()) {
+                return;
+            }
             boolean edgeTriggered = isFlagSet(Native.EPOLLET);
 
             final ChannelConfig config = config();

transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java

@@ -71,8 +71,6 @@ public abstract class AbstractEpollStreamChannel extends AbstractEpollChannel {
     private SocketAddress requestedRemoteAddress;
     private final Queue<SpliceInTask> spliceQueue = PlatformDependent.newMpscQueue();
 
-    private volatile boolean outputShutdown;
-
     // Lazy init these if we need to splice(...)
     private FileDescriptor pipeIn;
     private FileDescriptor pipeOut;
@@ -528,14 +526,9 @@ public abstract class AbstractEpollStreamChannel extends AbstractEpollChannel {
                 "unsupported message type: " + StringUtil.simpleClassName(msg) + EXPECTED_TYPES);
     }
 
-    protected boolean isOutputShutdown0() {
-        return outputShutdown || !isActive();
-    }
-
     protected void shutdownOutput0(final ChannelPromise promise) {
         try {
             fd().shutdown(false, true);
-            outputShutdown = true;
             promise.setSuccess();
         } catch (Throwable cause) {
             promise.setFailure(cause);
@@ -773,6 +766,9 @@ public abstract class AbstractEpollStreamChannel extends AbstractEpollChannel {
 
         @Override
         void epollInReady() {
+            if (fd().isInputShutdown()) {
+                return;
+            }
             final ChannelConfig config = config();
             boolean edgeTriggered = isFlagSet(Native.EPOLLET);
 

transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java

@@ -522,6 +522,9 @@ public final class EpollDatagramChannel extends AbstractEpollChannel implements
         @Override
         void epollInReady() {
             assert eventLoop().inEventLoop();
+            if (fd().isInputShutdown()) {
+                return;
+            }
             DatagramChannelConfig config = config();
             boolean edgeTriggered = isFlagSet(Native.EPOLLET);
 

transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannel.java

@@ -148,6 +148,9 @@ public final class EpollDomainSocketChannel extends AbstractEpollStreamChannel i
         }
 
         private void epollInReadFd() {
+            if (fd().isInputShutdown()) {
+                return;
+            }
             boolean edgeTriggered = isFlagSet(Native.EPOLLET);
             final ChannelConfig config = config();
             if (!readPending && !edgeTriggered && !config.isAutoRead()) {

transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java

@@ -324,7 +324,7 @@ final class EpollEventLoop extends SingleThreadEventLoop {
                     // In either case epollOutReady() will do the correct thing (finish connecting, or fail
                     // the connection).
                     // See https://github.com/netty/netty/issues/3848
-                    if ((ev & (Native.EPOLLERR | Native.EPOLLOUT)) != 0 && ch.isOpen()) {
+                    if ((ev & (Native.EPOLLERR | Native.EPOLLOUT)) != 0) {
                         // Force flush of data as the epoll is writable again
                         unsafe.epollOutReady();
                     }
@@ -334,7 +334,7 @@ final class EpollEventLoop extends SingleThreadEventLoop {
                     //
                     // If EPOLLIN or EPOLLERR was received and the channel is still open call epollInReady(). This will
                     // try to read from the underlying file descriptor and so notify the user about the error.
-                    if ((ev & (Native.EPOLLERR | Native.EPOLLIN)) != 0 && ch.isOpen()) {
+                    if ((ev & (Native.EPOLLERR | Native.EPOLLIN)) != 0) {
                         // The Channel is still open and there is something to read. Do it now.
                         unsafe.epollInReady();
                     }

transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java

@@ -149,12 +149,12 @@ public final class EpollSocketChannel extends AbstractEpollStreamChannel impleme
 
     @Override
     public boolean isInputShutdown() {
-        return isInputShutdown0();
+        return fd().isInputShutdown();
     }
 
     @Override
     public boolean isOutputShutdown() {
-        return isOutputShutdown0();
+        return fd().isOutputShutdown();
     }
 
     @Override

transport-native-epoll/src/main/java/io/netty/channel/unix/Socket.java

@@ -58,6 +58,10 @@ public final class Socket extends FileDescriptor {
         }
     }
 
+    public void shutdown() throws IOException {
+        shutdown(true, true);
+    }
+
     public boolean isShutdown() {
         return isInputShutdown() && isOutputShutdown();
     }