andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Not log notify failure for DelegatingChannelPromiseNotifier when promise is VoidChannelPromise

Browse Source 
Motivation:

We should not log by default if the promise is a VoidChannelPromise as its try* methods will always return false.

Modifications:

Do an instanceof check to determine if we should log or not by default

Result:

No more noise in the logs when using a VoidChannelPromise.
This commit is contained in:
Norman Maurer 2017-09-06 14:01:42 +02:00
parent e500755086
commit a739d89792
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/channel/DelegatingChannelPromiseNotifier.java
View File

@ -36,7 +36,7 @@ public final class DelegatingChannelPromiseNotifier implements ChannelPromise, C
private final boolean logNotifyFailure; private final boolean logNotifyFailure;
public DelegatingChannelPromiseNotifier(ChannelPromise delegate) { public DelegatingChannelPromiseNotifier(ChannelPromise delegate) {
this(delegate, true); this(delegate, !(delegate instanceof VoidChannelPromise));
} }
public DelegatingChannelPromiseNotifier(ChannelPromise delegate, boolean logNotifyFailure) { public DelegatingChannelPromiseNotifier(ChannelPromise delegate, boolean logNotifyFailure) {