andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed buffer leaks in LoggingHandlerTest

Browse Source
This commit is contained in:
Trustin Lee 2013-12-07 11:59:53 +09:00
parent 86c4166c24
commit a8bc720977
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
handler/src/test/java/io/netty/handler/logging/LoggingHandlerTest.java
View File

@ -40,6 +40,7 @@ import java.util.Iterator;
import java.util.List; import java.util.List;
import static org.easymock.EasyMock.*; import static org.easymock.EasyMock.*;
import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.*; import static org.junit.Assert.*;
/** /**
@ -208,6 +209,10 @@ public class LoggingHandlerTest {
EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler()); EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler());
channel.writeInbound(msg); channel.writeInbound(msg);
verify(appender); verify(appender);
String handledMsg = (String) channel.readInbound();
assertThat(msg, is(sameInstance(handledMsg)));
assertThat(channel.readInbound(), is(nullValue()));
} }
@Test @Test
@ -218,6 +223,11 @@ public class LoggingHandlerTest {
EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler()); EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler());
channel.writeInbound(msg); channel.writeInbound(msg);
verify(appender); verify(appender);
ByteBuf handledMsg = (ByteBuf) channel.readInbound();
assertThat(msg, is(sameInstance(handledMsg)));
handledMsg.release();
assertThat(channel.readInbound(), is(nullValue()));
} }
@Test @Test
@ -228,6 +238,10 @@ public class LoggingHandlerTest {
EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler()); EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler());
channel.writeInbound(msg); channel.writeInbound(msg);
verify(appender); verify(appender);
ByteBuf handledMsg = (ByteBuf) channel.readInbound();
assertThat(msg, is(sameInstance(handledMsg)));
assertThat(channel.readInbound(), is(nullValue()));
} }
@Test @Test
@ -244,6 +258,11 @@ public class LoggingHandlerTest {
EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler()); EmbeddedChannel channel = new EmbeddedChannel(new LoggingHandler());
channel.writeInbound(msg); channel.writeInbound(msg);
verify(appender); verify(appender);
ByteBufHolder handledMsg = (ByteBufHolder) channel.readInbound();
assertThat(msg, is(sameInstance(handledMsg)));
handledMsg.release();
assertThat(channel.readInbound(), is(nullValue()));
} }
/** /**