andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

More advice on extending OMATPE

Browse Source
This commit is contained in:
Trustin Lee 2009-07-21 10:33:58 +00:00
parent 1a54f32a77
commit a92142e493
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/org/jboss/netty/handler/execution/OrderedMemoryAwareThreadPoolExecutor.java
View File

@ -24,6 +24,7 @@ package org.jboss.netty.handler.execution;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.Set; import java.util.Set;
import java.util.WeakHashMap;
import java.util.concurrent.ConcurrentMap; import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.Executor; import java.util.concurrent.Executor;
import java.util.concurrent.ThreadFactory; import java.util.concurrent.ThreadFactory;
@ -104,7 +105,7 @@ import org.jboss.netty.util.internal.ConcurrentIdentityWeakKeyHashMap;
* ends (e.g. all connections from the same IP were closed.) Also, please * ends (e.g. all connections from the same IP were closed.) Also, please
* keep in mind that the key can appear again after calling {@link #removeChildExecutor(Object)} * keep in mind that the key can appear again after calling {@link #removeChildExecutor(Object)}
* (e.g. a new connection could come in from the old IP.) If in doubt, prune * (e.g. a new connection could come in from the old IP.) If in doubt, prune
* the old unused keys from the child executor map periodically: * the old unused or stall keys from the child executor map periodically:
* *
* <pre> * <pre>
* RemoteAddressBasedOMATPE executor = ...; * RemoteAddressBasedOMATPE executor = ...;
@ -120,6 +121,11 @@ import org.jboss.netty.util.internal.ConcurrentIdentityWeakKeyHashMap;
* } * }
* </pre> * </pre>
* *
* If the expected maximum number of keys is small and deterministic, you could
* use a weak key map such as <a href="http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbosscache/experimental/jsr166/src/jsr166y/ConcurrentWeakHashMap.java?view=markup">ConcurrentWeakHashMap</a>
* or synchronized {@link WeakHashMap} instead of managing the life cycle of the
* keys by yourself.
*
* @author The Netty Project (netty-dev@lists.jboss.org) * @author The Netty Project (netty-dev@lists.jboss.org)
* @author Trustin Lee (tlee@redhat.com) * @author Trustin Lee (tlee@redhat.com)
* @author David M. Lloyd (david.lloyd@redhat.com) * @author David M. Lloyd (david.lloyd@redhat.com)