Remove methods overridden but identical with the super implementation / Make constructors of abstract classes protected rather than non-sense public

AbstractWrappedByteBuf.capacity(int) should raise a UnsupportedOperationException rather than ReadOnlyBufferException.

src/main/java/org/jboss/netty/buffer/HeapChannelBuffer.java

@@ -38,7 +38,7 @@ public abstract class HeapChannelBuffer extends AbstractChannelBuffer {
      *
      * @param length the length of the new byte array
      */
-    public HeapChannelBuffer(int length) {
+    protected HeapChannelBuffer(int length) {
         this(new byte[length], 0, 0);
     }
 
@@ -47,7 +47,7 @@ public abstract class HeapChannelBuffer extends AbstractChannelBuffer {
      *
      * @param array the byte array to wrap
      */
-    public HeapChannelBuffer(byte[] array) {
+    protected HeapChannelBuffer(byte[] array) {
         this(array, 0, array.length);
     }
 

src/main/java/org/jboss/netty/channel/socket/oio/AbstractOioWorker.java

@@ -46,7 +46,7 @@ abstract class AbstractOioWorker<C extends AbstractOioChannel> implements Worker
 
     private volatile boolean done;
 
-    public AbstractOioWorker(C channel) {
+    protected AbstractOioWorker(C channel) {
         this.channel = channel;
         channel.worker = this;
     }

src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java

@@ -37,7 +37,7 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
     private boolean isRenamed;
     private FileChannel fileChannel;
 
-    public AbstractDiskHttpData(String name, Charset charset, long size) {
+    protected AbstractDiskHttpData(String name, Charset charset, long size) {
         super(name, charset, size);
     }
 

src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractHttpData.java

@@ -30,7 +30,7 @@ public abstract class AbstractHttpData implements HttpData {
     protected Charset charset = HttpConstants.DEFAULT_CHARSET;
     protected boolean completed;
 
-    public AbstractHttpData(String name, Charset charset, long size) {
+    protected AbstractHttpData(String name, Charset charset, long size) {
         if (name == null) {
             throw new NullPointerException("name");
         }

src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java

@@ -37,7 +37,7 @@ public abstract class AbstractMemoryHttpData extends AbstractHttpData {
     private int chunkPosition;
     protected boolean isRenamed;
 
-    public AbstractMemoryHttpData(String name, Charset charset, long size) {
+    protected AbstractMemoryHttpData(String name, Charset charset, long size) {
         super(name, charset, size);
     }
 

src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java

@@ -54,8 +54,8 @@ public abstract class WebSocketClientHandshaker {
      * @param customHeaders
      *            Map of custom headers to add to the client request
      */
-    public WebSocketClientHandshaker(URI webSocketUrl, WebSocketVersion version, String subprotocol,
-            Map<String, String> customHeaders) {
+    protected WebSocketClientHandshaker(URI webSocketUrl, WebSocketVersion version, String subprotocol,
+                                        Map<String, String> customHeaders) {
         this(webSocketUrl, version, subprotocol, customHeaders, Long.MAX_VALUE);
     }
 
@@ -74,8 +74,8 @@ public abstract class WebSocketClientHandshaker {
      * @param maxFramePayloadLength
      *            Maximum length of a frame's payload
      */
-    public WebSocketClientHandshaker(URI webSocketUrl, WebSocketVersion version, String subprotocol,
-            Map<String, String> customHeaders, long maxFramePayloadLength) {
+    protected WebSocketClientHandshaker(URI webSocketUrl, WebSocketVersion version, String subprotocol,
+                                        Map<String, String> customHeaders, long maxFramePayloadLength) {
         this.webSocketUrl = webSocketUrl;
         this.version = version;
         expectedSubprotocol = subprotocol;

src/main/java/org/jboss/netty/handler/codec/spdy/SpdyOrHttpChooser.java

@@ -47,7 +47,7 @@ public abstract class SpdyOrHttpChooser implements ChannelUpstreamHandler {
     private final int maxSpdyContentLength;
     private final int maxHttpContentLength;
 
-    public SpdyOrHttpChooser(int maxSpdyContentLength, int maxHttpContentLength) {
+    protected SpdyOrHttpChooser(int maxSpdyContentLength, int maxHttpContentLength) {
         this.maxSpdyContentLength = maxSpdyContentLength;
         this.maxHttpContentLength = maxHttpContentLength;
     }

src/main/java/org/jboss/netty/handler/execution/ChannelEventRunnable.java

@@ -38,7 +38,7 @@ public abstract class ChannelEventRunnable implements Runnable, EstimatableObjec
      * Creates a {@link Runnable} which sends the specified {@link ChannelEvent}
      * upstream via the specified {@link ChannelHandlerContext}.
      */
-    public ChannelEventRunnable(ChannelHandlerContext ctx, ChannelEvent e, Executor executor) {
+    protected ChannelEventRunnable(ChannelHandlerContext ctx, ChannelEvent e, Executor executor) {
         this.ctx = ctx;
         this.e = e;
         this.executor = executor;

src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java

@@ -148,8 +148,8 @@ public abstract class AbstractTrafficShapingHandler extends
      *          The delay between two computations of performances for
      *            channels or 0 if no stats are to be computed
      */
-    public AbstractTrafficShapingHandler(Timer timer, long writeLimit,
-            long readLimit, long checkInterval) {
+    protected AbstractTrafficShapingHandler(Timer timer, long writeLimit,
+                                            long readLimit, long checkInterval) {
         init(new DefaultObjectSizeEstimator(), timer, writeLimit, readLimit, checkInterval);
     }
 
@@ -169,7 +169,7 @@ public abstract class AbstractTrafficShapingHandler extends
      *          The delay between two computations of performances for
      *            channels or 0 if no stats are to be computed
      */
-    public AbstractTrafficShapingHandler(
+    protected AbstractTrafficShapingHandler(
             ObjectSizeEstimator objectSizeEstimator, Timer timer,
             long writeLimit, long readLimit, long checkInterval) {
         init(objectSizeEstimator, timer, writeLimit, readLimit, checkInterval);
@@ -185,8 +185,8 @@ public abstract class AbstractTrafficShapingHandler extends
      * @param readLimit
      *          0 or a limit in bytes/s
      */
-    public AbstractTrafficShapingHandler(Timer timer, long writeLimit,
-            long readLimit) {
+    protected AbstractTrafficShapingHandler(Timer timer, long writeLimit,
+                                            long readLimit) {
         init(new DefaultObjectSizeEstimator(), timer, writeLimit, readLimit, DEFAULT_CHECK_INTERVAL);
     }
 
@@ -203,7 +203,7 @@ public abstract class AbstractTrafficShapingHandler extends
      * @param readLimit
      *          0 or a limit in bytes/s
      */
-    public AbstractTrafficShapingHandler(
+    protected AbstractTrafficShapingHandler(
             ObjectSizeEstimator objectSizeEstimator, Timer timer,
             long writeLimit, long readLimit) {
         init(objectSizeEstimator, timer, writeLimit, readLimit, DEFAULT_CHECK_INTERVAL);
@@ -215,7 +215,7 @@ public abstract class AbstractTrafficShapingHandler extends
      * @param timer
      *          created once for instance like HashedWheelTimer(10, TimeUnit.MILLISECONDS, 1024)
      */
-    public AbstractTrafficShapingHandler(Timer timer) {
+    protected AbstractTrafficShapingHandler(Timer timer) {
         init(new DefaultObjectSizeEstimator(), timer, 0, 0, DEFAULT_CHECK_INTERVAL);
     }
 
@@ -228,7 +228,7 @@ public abstract class AbstractTrafficShapingHandler extends
      * @param timer
      *          created once for instance like HashedWheelTimer(10, TimeUnit.MILLISECONDS, 1024)
      */
-    public AbstractTrafficShapingHandler(
+    protected AbstractTrafficShapingHandler(
             ObjectSizeEstimator objectSizeEstimator, Timer timer) {
         init(objectSizeEstimator, timer, 0, 0, DEFAULT_CHECK_INTERVAL);
     }
@@ -242,7 +242,7 @@ public abstract class AbstractTrafficShapingHandler extends
      *          The delay between two computations of performances for
      *            channels or 0 if no stats are to be computed
      */
-    public AbstractTrafficShapingHandler(Timer timer, long checkInterval) {
+    protected AbstractTrafficShapingHandler(Timer timer, long checkInterval) {
         init(new DefaultObjectSizeEstimator(), timer, 0, 0, checkInterval);
     }
 
@@ -258,7 +258,7 @@ public abstract class AbstractTrafficShapingHandler extends
      *          The delay between two computations of performances for
      *            channels or 0 if no stats are to be computed
      */
-    public AbstractTrafficShapingHandler(
+    protected AbstractTrafficShapingHandler(
             ObjectSizeEstimator objectSizeEstimator, Timer timer,
             long checkInterval) {
         init(objectSizeEstimator, timer, 0, 0, checkInterval);