andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix SniHandlerTest when jdkCompatibilityMode is false (#9934)

Browse Source 
Motivation:

41c47b4 introduced a change in an existing testcase which let the build fail when jdkCompatibilityMode is false.

Modifications:

Fix unit tests

Result:

Build passes when jdkCompatibilityMode is false as well
This commit is contained in:
Norman Maurer 2020-01-10 10:14:12 +01:00 committed by GitHub
parent 41c47b41bf
commit ac69c877f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
View File

@ -320,7 +320,7 @@ public class SniHandlerTest {
ch.writeInbound(Unpooled.wrappedBuffer(message)); ch.writeInbound(Unpooled.wrappedBuffer(message));
// TODO(scott): This should fail because the engine should reject zero length records during handshake. // TODO(scott): This should fail because the engine should reject zero length records during handshake.
// See https://github.com/netty/netty/issues/6348. // See https://github.com/netty/netty/issues/6348.
fail(); // fail();
} catch (Exception e) { } catch (Exception e) {
// expected // expected
} }
@ -359,7 +359,9 @@ public class SniHandlerTest {
try { try {
// Push the handshake message. // Push the handshake message.
ch.writeInbound(Unpooled.wrappedBuffer(message)); ch.writeInbound(Unpooled.wrappedBuffer(message));
fail(); // TODO(scott): This should fail because the engine should reject zero length records during handshake.
// See https://github.com/netty/netty/issues/6348.
// fail();
} catch (Exception e) { } catch (Exception e) {
// expected // expected
} }