andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use MACOSX_DEPLOYMENT_TARGET=10.6 when compile native transport on MacOS (#8379)

Browse Source 
Motivation:

MACOSX_DEPLOYMENT_TARGET=10.6 needs to be used as everything before is not supported in 10.14 anymore. 10.6 was released 2009 so this should be a safe thing to do.

Modifications:

Use MACOSX_DEPLOYMENT_TARGET=10.6

Result:

Be able to compile on MacOS 10.14
This commit is contained in:
Norman Maurer 2018-10-13 04:25:56 +02:00 committed by GitHub
parent aae7cdca96
commit adb4ce1f31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
transport-native-kqueue/pom.xml
View File

@ -80,10 +80,10 @@
<configureArgs> <configureArgs>
<arg>${jni.compiler.args.ldflags}</arg> <arg>${jni.compiler.args.ldflags}</arg>
<arg>${jni.compiler.args.cflags}</arg> <arg>${jni.compiler.args.cflags}</arg>
<!-- support for __attribute__((weak_import)) by the linker was added in 10.2 so ensure we <!-- support for __attribute__((weak_import)) by the linker was added in 10.2 (but 10.6 is the minimum we can use on 10.14) so ensure we
explicitly set the target platform. Otherwise we may get fatal link errors due to weakly linked explicitly set the target platform. Otherwise we may get fatal link errors due to weakly linked
methods which are not expected to be present on MacOS (e.g. accept4). --> methods which are not expected to be present on MacOS (e.g. accept4). -->
<arg>MACOSX_DEPLOYMENT_TARGET=10.2</arg> <arg>MACOSX_DEPLOYMENT_TARGET=10.6</arg>
</configureArgs> </configureArgs>
</configuration> </configuration>
<goals> <goals>