andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix for ByteString#hashCode()

Browse Source 
Motivation:

ByteString#hashCode() trashes its own hash code if it's being accessed concurrently

Modifications:

Pull the ByteString#hash into a local variable and calculate it locally.

Result:

ByteString#hashCode() is no longer returning a junk value.
This commit is contained in:
Roger Kapsi 2015-04-16 18:27:11 -04:00 committed by Scott Mitchell
parent 7e8ab2118d
commit afadb98d9d
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/src/main/java/io/netty/util/ByteString.java
View File

@ -393,15 +393,15 @@ public class ByteString {
@Override @Override
public int hashCode() { public int hashCode() {
if (hash != 0) { int h = hash;
return hash; if (h == 0) {
}
for (int i = 0; i < value.length; ++i) { for (int i = 0; i < value.length; ++i) {
hash = hash * HASH_CODE_PRIME ^ value[i] & HASH_CODE_PRIME; h = h * HASH_CODE_PRIME ^ value[i] & HASH_CODE_PRIME;
} }
return hash; hash = h;
}
return h;
} }
/** /**