andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2605] Use SO_REUSEADDR on EpollServerSocketChannel to match defaults of java.nio.ServerSocketChannel impl

Browse Source 
Motivation:

When using openjdk and oracle jdk's nio (while using the nio transport) the ServerSocketChannel uses SO_REUSEADDR by default. Our native transport should do the same to make it easier to switch between the different implementations and get the expected result.

Modification:

Change EpollServerSocketChannelConfig to set SO_REUSEADDR on the created socket.

Result:

SO_REUSEADDR is used by default on servers.
This commit is contained in:
Norman Maurer 2014-06-26 11:53:23 +02:00
parent d2e385acc2
commit b0e5c9be00
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerSocketChannelConfig.java
View File

@ -38,6 +38,11 @@ public final class EpollServerSocketChannelConfig extends DefaultChannelConfig
EpollServerSocketChannelConfig(EpollServerSocketChannel channel) { EpollServerSocketChannelConfig(EpollServerSocketChannel channel) {
super(channel); super(channel);
this.channel = channel; this.channel = channel;
// Use SO_REUSEADDR by default as java.nio does the same.
//
// See https://github.com/netty/netty/issues/2605
setReuseAddress(true);
} }
@Override @Override