From b1a156d3f2c86c78f64da0def78727b0952018da Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Thu, 7 Jun 2012 09:15:53 +0900 Subject: [PATCH] Fix a build failure due to a dependency problem / Fix checkstyle errors --- handler/pom.xml | 1 - .../main/java/io/netty/handler/logging/LoggingHandler.java | 2 +- handler/src/main/java/io/netty/handler/ssl/SslHandler.java | 2 +- .../java/io/netty/handler/timeout/ReadTimeoutException.java | 4 ++-- .../main/java/io/netty/handler/timeout/TimeoutException.java | 2 +- .../java/io/netty/handler/timeout/WriteTimeoutException.java | 4 ++-- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/handler/pom.xml b/handler/pom.xml index 0e7327d928..5f39fea800 100644 --- a/handler/pom.xml +++ b/handler/pom.xml @@ -43,7 +43,6 @@ ${project.groupId} netty-codec ${project.version} - test diff --git a/handler/src/main/java/io/netty/handler/logging/LoggingHandler.java b/handler/src/main/java/io/netty/handler/logging/LoggingHandler.java index 35ba75173b..d9b0d5092b 100644 --- a/handler/src/main/java/io/netty/handler/logging/LoggingHandler.java +++ b/handler/src/main/java/io/netty/handler/logging/LoggingHandler.java @@ -60,7 +60,7 @@ public class LoggingHandler extends ChannelHandlerAdapter { buf.append(i); BYTE2HEX[i] = buf.toString(); } - for (;i < 16; i ++) { + for (; i < 16; i ++) { StringBuilder buf = new StringBuilder(3); buf.append(" 0"); buf.append((char) ('a' + i - 10)); diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java index 66d671f3da..f2f752e496 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java @@ -466,7 +466,7 @@ public class SslHandler extends StreamToStreamCodec { try { ByteBuffer outAppBuf = in.nioBuffer(); - while(in.readable()) { + while (in.readable()) { int read; int remaining = outAppBuf.remaining(); diff --git a/handler/src/main/java/io/netty/handler/timeout/ReadTimeoutException.java b/handler/src/main/java/io/netty/handler/timeout/ReadTimeoutException.java index afb597fb44..b0aaa951d2 100644 --- a/handler/src/main/java/io/netty/handler/timeout/ReadTimeoutException.java +++ b/handler/src/main/java/io/netty/handler/timeout/ReadTimeoutException.java @@ -19,11 +19,11 @@ package io.netty.handler.timeout; * A {@link TimeoutException} raised by {@link ReadTimeoutHandler} when no data * was read within a certain period of time. */ -public class ReadTimeoutException extends TimeoutException { +public final class ReadTimeoutException extends TimeoutException { private static final long serialVersionUID = 169287984113283421L; public static final ReadTimeoutException INSTANCE = new ReadTimeoutException(); - private ReadTimeoutException() {} + private ReadTimeoutException() { } } diff --git a/handler/src/main/java/io/netty/handler/timeout/TimeoutException.java b/handler/src/main/java/io/netty/handler/timeout/TimeoutException.java index 17f654568e..072220bed9 100644 --- a/handler/src/main/java/io/netty/handler/timeout/TimeoutException.java +++ b/handler/src/main/java/io/netty/handler/timeout/TimeoutException.java @@ -25,7 +25,7 @@ public class TimeoutException extends ChannelException { private static final long serialVersionUID = 4673641882869672533L; - TimeoutException() {} + TimeoutException() { } @Override public Throwable fillInStackTrace() { diff --git a/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutException.java b/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutException.java index 7ad039a27a..f728608a4e 100644 --- a/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutException.java +++ b/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutException.java @@ -19,11 +19,11 @@ package io.netty.handler.timeout; * A {@link TimeoutException} raised by {@link WriteTimeoutHandler} when no data * was written within a certain period of time. */ -public class WriteTimeoutException extends TimeoutException { +public final class WriteTimeoutException extends TimeoutException { private static final long serialVersionUID = -144786655770296065L; public static final WriteTimeoutException INSTANCE = new WriteTimeoutException(); - private WriteTimeoutException() {} + private WriteTimeoutException() { } }