From b3500f50a61a4fa21a4344d8a08221f6038d1925 Mon Sep 17 00:00:00 2001 From: Oleksii Kachaiev Date: Tue, 22 Jan 2019 17:41:15 +0200 Subject: [PATCH] Java 8 migration. Replace Collection.newSetFromMap with ConcurrentHashMap.newKeySet (#8756) Motivation: Simplify code with newer Java API. It also reduce levels of indirection, but I don't think we can gain any visible performance improvements out of this. Modifications: Replace Collection.newSetFromMap(new ConcurrentHashMap()) with ConcurrentHashMap.newKeySet(). Result: Use Java8 APIs. --- common/src/main/java/io/netty/util/ResourceLeakDetector.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/common/src/main/java/io/netty/util/ResourceLeakDetector.java b/common/src/main/java/io/netty/util/ResourceLeakDetector.java index 5dfc799d32..b95ef4bf8c 100644 --- a/common/src/main/java/io/netty/util/ResourceLeakDetector.java +++ b/common/src/main/java/io/netty/util/ResourceLeakDetector.java @@ -26,7 +26,6 @@ import java.lang.ref.WeakReference; import java.lang.ref.ReferenceQueue; import java.lang.reflect.Method; import java.util.Arrays; -import java.util.Collections; import java.util.HashSet; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; @@ -164,8 +163,7 @@ public class ResourceLeakDetector { } /** the collection of active resources */ - private final Set> allLeaks = - Collections.newSetFromMap(new ConcurrentHashMap<>()); + private final Set> allLeaks = ConcurrentHashMap.newKeySet(); private final ReferenceQueue refQueue = new ReferenceQueue<>(); private final ConcurrentMap reportedLeaks = PlatformDependent.newConcurrentHashMap();