andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2159] Not fail the ChannelPromise with WriteTimeoutException to prevent warning

Browse Source
This commit is contained in:
Norman Maurer 2014-01-29 13:56:42 +01:00
parent 96f94cfcb1
commit b3e4122499
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java
View File

@ -111,8 +111,10 @@ public class WriteTimeoutHandler extends ChannelHandlerAdapter {
final ScheduledFuture<?> sf = ctx.executor().schedule(new Runnable() { final ScheduledFuture<?> sf = ctx.executor().schedule(new Runnable() {
@Override @Override
public void run() { public void run() {
if (future.tryFailure(WriteTimeoutException.INSTANCE)) { // Was not written yet so issue a write timeout
// If succeeded to mark as failure, notify the pipeline, too. // The future itself will be failed with a ClosedChannelException once the close() was issued
// See https://github.com/netty/netty/issues/2159
if (!future.isDone()) {
try { try {
writeTimedOut(ctx); writeTimedOut(ctx);
} catch (Throwable t) { } catch (Throwable t) {