andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Handle the possibility of HTTP/0.9 with a better error message

Browse Source 
Motivation

RFC 1945 (see section 3.1) says that request lines may not have a version in which case the request is assumed to be HTTP/0.9. We don't necessarily want to support that but the existing Exception should indicate the possibility of the request being HTTP/0.9 and give the user a chance to track it down.

Modifications

Indicate in the Exception's message that the request is possibly HTTP/0.9.

Result

Fixes #6739
This commit is contained in:
Roger Kapsi 2017-05-25 11:29:24 -04:00 committed by Norman Maurer
parent ca9d1658a0
commit b419bd152a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java
View File

@ -60,7 +60,7 @@ public class HttpVersion implements Comparable<HttpVersion> {
text = text.trim(); text = text.trim();
if (text.isEmpty()) { if (text.isEmpty()) {
throw new IllegalArgumentException("text is empty"); throw new IllegalArgumentException("text is empty (possibly HTTP/0.9)");
} }
// Try to match without convert to uppercase first as this is what 99% of all clients // Try to match without convert to uppercase first as this is what 99% of all clients