andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a log level check simply before logging. (#10093)

Browse Source 
Motivation:

ThrowableUtil.stackTraceToString is an expensive method call. So I think a log level check before this logging statement is quite needed especially in a environment with the warning log disabled.

Modification:

Add log level check simply before logging.

Result:

Improve performance in a environment with the warning log disabled.
This commit is contained in:
feijermu 2020-03-09 15:47:53 +08:00 committed by GitHub
parent 660759b997
commit b892722efb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/src/main/java/io/netty/util/internal/PromiseNotificationUtil.java
View File

@ -65,7 +65,7 @@ public final class PromiseNotificationUtil {
Throwable err = p.cause(); Throwable err = p.cause();
if (err == null) { if (err == null) {
logger.warn("Failed to mark a promise as failure because it has succeeded already: {}", p, cause); logger.warn("Failed to mark a promise as failure because it has succeeded already: {}", p, cause);
} else { } else if (logger.isWarnEnabled()) {
logger.warn( logger.warn(
"Failed to mark a promise as failure because it has failed already: {}, unnotified cause: {}", "Failed to mark a promise as failure because it has failed already: {}, unnotified cause: {}",
p, ThrowableUtil.stackTraceToString(err), cause); p, ThrowableUtil.stackTraceToString(err), cause);