andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix SimpleChannelPoolTest#testCloseAsync() test flake (#9943)

Browse Source 
Motivation

This test is failing intermittently and upon inspection has a race
condition.

Modification

Fix race condition by waiting for async release calls to complete prior
to closing the pool.

Result

Hopefully fixed flakey test
This commit is contained in:
Nick Hill 2020-01-10 21:03:46 -08:00 committed by Norman Maurer
parent f7d357312f
commit ba140ac6bc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
transport/src/test/java/io/netty/channel/pool/SimpleChannelPoolTest.java
View File

@ -334,8 +334,8 @@ public class SimpleChannelPoolTest {
final SimpleChannelPool pool = new SimpleChannelPool(bootstrap, new CountingChannelPoolHandler());
Channel ch1 = pool.acquire().syncUninterruptibly().getNow();
Channel ch2 = pool.acquire().syncUninterruptibly().getNow();
pool.release(ch1);
pool.release(ch2);
pool.release(ch1).get(1, TimeUnit.SECONDS);
pool.release(ch2).get(1, TimeUnit.SECONDS);
// Assert that returned channels are open before close
assertTrue(ch1.isOpen());